libkcapi: split BR2_PACKAGE_LIBKCAPI_APPS
authorFabrice Fontaine <fontaine.fabrice@gmail.com>
Sun, 6 May 2018 22:09:01 +0000 (00:09 +0200)
committerThomas Petazzoni <thomas.petazzoni@bootlin.com>
Tue, 8 May 2018 13:23:14 +0000 (15:23 +0200)
Since commit https://github.com/smuellerDD/libkcapi/commit/af313accf18887b4f6dbd7306c2389ddf271c9b7,
hasher test application depends on dlfcn.h. To avoid putting all apps
under !BR2_STATIC_LIBS dependency, split BR2_PACKAGE_LIBKCAPI_APPS into
several variables.

Moreover, BR2_USE_MMU is only a dependency of BR2_PACKAGE_LIBKCAPI_TEST
as other applications don't use fork.

Finally, enc or dgst applications could be enabled in a next patch if
needed.

Fixes:
 - http://autobuild.buildroot.net/results/7c57f3025030eff41a5cde52759821249859caf1

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Config.in.legacy
package/libkcapi/Config.in
package/libkcapi/libkcapi.mk

index 3d8b28c5fe56f96e86b9484fcf8315a78b7c1a9c..c51984a3b947ffbb21300ed77f4f3ffce3528d4e 100644 (file)
@@ -145,6 +145,17 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2018.05"
 
+config BR2_PACKAGE_LIBKCAPI_APPS
+       bool "libkcapi test applications removed"
+       select BR2_LEGACY
+       select BR2_PACKAGE_LIBKCAPI_HASHER if !BR2_STATIC_LIBS
+       select BR2_PACKAGE_LIBKCAPI_RNGAPP
+       select BR2_PACKAGE_LIBKCAPI_SPEED
+       select BR2_PACKAGE_LIBKCAPI_TEST
+       help
+         Test applications (hasher, rng read, speed-test, test) now
+         have their own configuration options in the libkcapi menu.
+
 config BR2_PACKAGE_IQVLINUX
        bool "iqvlinux package removed"
        select BR2_LEGACY
index 2b981777e6acc699da4e2775fa49c949a1cf7792..7397cfe800c7fed727c8432b23df75a3d9fbc3c0 100644 (file)
@@ -7,11 +7,21 @@ config BR2_PACKAGE_LIBKCAPI
 
 if BR2_PACKAGE_LIBKCAPI
 
-config BR2_PACKAGE_LIBKCAPI_APPS
-       bool "build test applications"
+config BR2_PACKAGE_LIBKCAPI_HASHER
+       bool "build hasher application"
+       depends on !BR2_STATIC_LIBS # dlfcn.h
+
+comment "hasher application needs a toolchain w/ dynamic library"
+       depends on BR2_STATIC_LIBS
+
+config BR2_PACKAGE_LIBKCAPI_RNGAPP
+       bool "build rng read application"
+
+config BR2_PACKAGE_LIBKCAPI_SPEED
+       bool "build speed-test program"
+
+config BR2_PACKAGE_LIBKCAPI_TEST
+       bool "build test program"
        depends on BR2_USE_MMU # fork()
-       help
-         Build additional test applications that can provide
-         performance or algorithm tests.
 
 endif
index 44469017df6fe0ae93bbc20f4fea17a1ac0f785d..1a45f4f996dfd566cca78777f9214b1d5fbc3a36 100644 (file)
@@ -12,18 +12,28 @@ LIBKCAPI_INSTALL_STAGING = YES
 LIBKCAPI_LICENSE = BSD-3-Clause (library), BSD-3-Clause or GPL-2.0 (programs)
 LIBKCAPI_LICENSE_FILES = COPYING COPYING.gplv2 COPYING.bsd
 
-ifeq ($(BR2_PACKAGE_LIBKCAPI_APPS),y)
-LIBKCAPI_CONF_OPTS += \
-       --enable-kcapi-speed \
-       --enable-kcapi-test \
-       --enable-kcapi-hasher \
-       --enable-kcapi-rngapp
+ifeq ($(BR2_PACKAGE_LIBKCAPI_HASHER),y)
+LIBKCAPI_CONF_OPTS += --enable-kcapi-hasher
 else
-LIBKCAPI_CONF_OPTS += \
-       --disable-kcapi-speed \
-       --disable-kcapi-test \
-       --disable-kcapi-hasher \
-       --disable-kcapi-rngapp
+LIBKCAPI_CONF_OPTS += --disable-kcapi-hasher
+endif
+
+ifeq ($(BR2_PACKAGE_LIBKCAPI_RNGAPP),y)
+LIBKCAPI_CONF_OPTS += --enable-kcapi-rngapp
+else
+LIBKCAPI_CONF_OPTS += --disable-kcapi-rngapp
+endif
+
+ifeq ($(BR2_PACKAGE_LIBKCAPI_SPEED),y)
+LIBKCAPI_CONF_OPTS += --enable-kcapi-speed
+else
+LIBKCAPI_CONF_OPTS += --disable-kcapi-speed
+endif
+
+ifeq ($(BR2_PACKAGE_LIBKCAPI_TEST),y)
+LIBKCAPI_CONF_OPTS += --enable-kcapi-test
+else
+LIBKCAPI_CONF_OPTS += --disable-kcapi-test
 endif
 
 $(eval $(autotools-package))