vc4: Drop incorrect attempt to incorrectly invert the primconvert hw_mask.
authorEric Anholt <eric@anholt.net>
Wed, 13 Aug 2014 17:43:26 +0000 (10:43 -0700)
committerEric Anholt <eric@anholt.net>
Fri, 15 Aug 2014 19:01:32 +0000 (12:01 -0700)
The hw_mask is the set of primitives you actually support, so this attempt
to provide the set of formats that's unsupported was wrong in two ways (it
was intended to be '~' not '!').  However, we only call this code when
prim isn't one of the actually supported hw_mask bits, so missing out on
the memcpy didn't matter anyway.

src/gallium/drivers/vc4/vc4_context.c

index 2fc571a26ad36b54b3d884c3d40dd60885931d00..1ffaab12765e002a12f0d5eebac4d2c8a74b7293 100644 (file)
@@ -303,7 +303,7 @@ vc4_context_create(struct pipe_screen *pscreen, void *priv)
                 goto fail;
 
         vc4->primconvert = util_primconvert_create(pctx,
-                                                   !((1 << PIPE_PRIM_QUADS) - 1));
+                                                   (1 << PIPE_PRIM_QUADS) - 1);
         if (!vc4->primconvert)
                 goto fail;