Remove tui_source_window::content_in_use

Now that source window clearing has been simplified, we don't need a
special flag to say whether the source window is in use -- we can
simply check whether the contents are set.  This patch implements this
idea, removing the content_in_use field.

gdb/ChangeLog
2019-07-17  Tom Tromey  <tom@tromey.com>

	* tui/tui-winsource.c (tui_clear_source_content)
	(tui_show_source_content): Update.
	* tui/tui-source.c (tui_source_window::showing_source_p): Check
	whether content is empty.
	* tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
	Remove.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4b5a8760da9416ad0999f57b13d708c4b5016ff5..5ae3e3502f0b4a900bb7801e132d0e8a1c7d4d10 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,12 @@
+2019-07-17  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-winsource.c (tui_clear_source_content)
+       (tui_show_source_content): Update.
+       * tui/tui-source.c (tui_source_window::showing_source_p): Check
+       whether content is empty.
+       * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
+       Remove.
+
 2019-07-17  Tom Tromey  <tom@tromey.com>
 
        * tui/tui-winsource.c (tui_erase_source_content): Clear the

diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h
index 125b4ae4c5d8e4d2181113dfe8b0f6e8efa9b105..0245031c6cda61d9d20d8ce72dd6547012fa7a35 100644 (file)
--- a/gdb/tui/tui-data.h
+++ b/gdb/tui/tui-data.h
@@ -398,8 +398,6 @@ public:
      LINE_NO in this source window; false otherwise.  */
   virtual bool location_matches_p (struct bp_location *loc, int line_no) = 0;
 
-  /* Can it be used, or is it already used?  */
-  bool content_in_use = false;
   /* Does the locator belong to this window?  */
   bool m_has_locator = false;
   /* Execution information window.  */

diff --git a/gdb/tui/tui-source.c b/gdb/tui/tui-source.c
index d3cce1c30033678971e588b1d5cc37aebed2a9c4..f0bac24bfea4d6b5837cee4603ab605bc97567e1 100644 (file)
--- a/gdb/tui/tui-source.c
+++ b/gdb/tui/tui-source.c
@@ -227,7 +227,7 @@ tui_show_symtab_source (tui_source_window_base *win_info,
 bool
 tui_source_window::showing_source_p (const char *fullname) const
 {
-  return (content_in_use 
+  return (!content.empty ()
          && (filename_cmp (tui_locator_win_info_ptr ()->full_name,
                            fullname) == 0));
 }

diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c
index 2be20492f477f81f0efb277abb212d185f8d177e..39591db2cc9b663f0e935786be86b1839e697a5a 100644 (file)
--- a/gdb/tui/tui-winsource.c
+++ b/gdb/tui/tui-winsource.c
@@ -211,7 +211,6 @@ tui_clear_source_content (struct tui_source_window_base *win_info)
     {
       int i;
 
-      win_info->content_in_use = false;
       tui_erase_source_content (win_info);
       for (i = 0; i < win_info->content.size (); i++)
        {
@@ -297,7 +296,6 @@ tui_show_source_content (struct tui_source_window_base *win_info)
 
   tui_check_and_display_highlight_if_needed (win_info);
   win_info->refresh_window ();
-  win_info->content_in_use = true;
 }
 
 /* See tui-data.h.  */