re PR target/70450 (Wrong code with -O0 and -O1.)

2016-03-30  Richard Biener  <rguenther@suse.de>

	PR middle-end/70450
	* fold-const.c (extract_muldiv_1): Fix thinko in wide_int::from
	usage.

	* gcc.dg/torture/pr70450.c: New testcase.

From-SVN: r234571

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index db870ff9689c0650d45b1835cd1f6f4c2b99b77b..35af4ecac720b01b32b22a73e8b784babeb296c2 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2016-03-30  Richard Biener  <rguenther@suse.de>
+
+       PR middle-end/70450
+       * fold-const.c (extract_muldiv_1): Fix thinko in wide_int::from
+       usage.
+
 2016-03-30  Jakub Jelinek  <jakub@redhat.com>
 
        PR target/70421

diff --git a/gcc/fold-const.c b/gcc/fold-const.c
index 44fe2a27d4f58ff0c6c0eae6897fea512c1eddfa..788ecc3a6b7d53fe732720a07a9b6a30fe364c36 100644 (file)
--- a/gcc/fold-const.c
+++ b/gcc/fold-const.c
@@ -6375,8 +6375,10 @@ extract_muldiv_1 (tree t, tree c, enum tree_code code, tree wide_type,
          bool overflow_mul_p;
          signop sign = TYPE_SIGN (ctype);
          unsigned prec = TYPE_PRECISION (ctype);
-         wide_int mul = wi::mul (wide_int::from (op1, prec, sign),
-                                 wide_int::from (c, prec, sign),
+         wide_int mul = wi::mul (wide_int::from (op1, prec,
+                                                 TYPE_SIGN (TREE_TYPE (op1))),
+                                 wide_int::from (c, prec,
+                                                 TYPE_SIGN (TREE_TYPE (c))),
                                  sign, &overflow_mul_p);
          overflow_p = TREE_OVERFLOW (c) | TREE_OVERFLOW (op1);
          if (overflow_mul_p

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index b2dfebfa0a75b6293705dbc58ebbe6bd6e2114f5..658e6c51a6bb9feb9d9872e8532fe2ede48ebbda 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2016-03-30  Richard Biener  <rguenther@suse.de>
+
+       PR middle-end/70450
+       * gcc.dg/torture/pr70450.c: New testcase.
+
 2016-03-30  Jakub Jelinek  <jakub@redhat.com>
 
        PR target/70421

diff --git a/gcc/testsuite/gcc.dg/torture/pr70450.c b/gcc/testsuite/gcc.dg/torture/pr70450.c
new file mode 100644 (file)
index 0000000..ee5e24d
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/torture/pr70450.c
@@ -0,0 +1,19 @@
+/* { dg-do run } */
+/* { dg-require-effective-target lp64 } */
+
+unsigned long int a = 2UL;
+int b = 2;
+unsigned long int c = 2UL;
+
+void foo ()
+{
+  c = 2 * ((2 * a) * (2 * (-b)));
+}
+
+int main ()
+{
+  foo();
+  if (c != 18446744073709551584UL)
+    __builtin_abort();
+  return 0;
+}