analyzer: fix ICE when handling callback exceeds enode limit [PR97514]
authorDavid Malcolm <dmalcolm@redhat.com>
Thu, 22 Oct 2020 10:16:28 +0000 (06:16 -0400)
committerDavid Malcolm <dmalcolm@redhat.com>
Thu, 22 Oct 2020 10:16:28 +0000 (06:16 -0400)
gcc/analyzer/ChangeLog:
PR analyzer/97514
* engine.cc (exploded_graph::add_function_entry): Handle failure
to create an enode, rather than asserting.

gcc/testsuite/ChangeLog:
PR analyzer/97514
* gcc.dg/analyzer/pr97514.c: New test.

gcc/analyzer/engine.cc
gcc/testsuite/gcc.dg/analyzer/pr97514.c [new file with mode: 0644]

index b1c877e52315e318f3d5c96b6b10deaa828b6693..d4c654a34978ce93d952570315412b3522855986 100644 (file)
@@ -1956,8 +1956,9 @@ exploded_graph::add_function_entry (function *fun)
     return NULL;
 
   exploded_node *enode = get_or_create_node (point, state, NULL);
-  /* We should never fail to add such a node.  */
-  gcc_assert (enode);
+  if (!enode)
+    return NULL;
+
   add_edge (m_origin, enode, NULL);
 
   m_functions_with_enodes.add (fun);
diff --git a/gcc/testsuite/gcc.dg/analyzer/pr97514.c b/gcc/testsuite/gcc.dg/analyzer/pr97514.c
new file mode 100644 (file)
index 0000000..27245f4
--- /dev/null
@@ -0,0 +1,18 @@
+/* { dg-additional-options "--param analyzer-max-enodes-per-program-point=0 -Wno-analyzer-too-complex" } */
+
+typedef void (*sighandler_t) (int);
+
+void
+signal (int, sighandler_t);
+
+static void
+kw (int signum)
+{
+  (void) signum;
+}
+
+void
+gk (int ot)
+{
+  signal (ot, kw);
+}