mesa: reset offset/size to 0 when removing atomic binding
authorIlia Mirkin <imirkin@alum.mit.edu>
Fri, 12 Feb 2016 18:49:08 +0000 (13:49 -0500)
committerIlia Mirkin <imirkin@alum.mit.edu>
Fri, 12 Feb 2016 23:22:49 +0000 (18:22 -0500)
Similar to commit dd9d2963d6 (mesa: AtomicBufferBindings should be
initialized to zero.), we should reset these to zero when unbinding.
This fixes a number of dEQP failures due to cross-test pollution. The
tests properly unbound everything, but when querying the values again,
the expectation was that they would be 0.

Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Reviewed-by: Brian Paul <brianp@vmware.com>
Reviewed-by: Francisco Jerez <currojerez@riseup.net>
src/mesa/main/bufferobj.c

index de1aba44c1b35c45fc51950dccb6621da3cf8772..9aec42508a7d59c172ab3e8d78f75bfcbf584b8a 100644 (file)
@@ -3007,8 +3007,8 @@ set_atomic_buffer_binding(struct gl_context *ctx,
    _mesa_reference_buffer_object(ctx, &binding->BufferObject, bufObj);
 
    if (bufObj == ctx->Shared->NullBufferObj) {
-      binding->Offset = -1;
-      binding->Size = -1;
+      binding->Offset = 0;
+      binding->Size = 0;
    } else {
       binding->Offset = offset;
       binding->Size = size;