projects / binutils-gdb.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 53892e6)
ld: Remove PF_X from PT_PHDR segment
authorH.J. Lu <hjl.tools@gmail.com>
Mon, 13 Nov 2017 01:03:50 +0000 (17:03 -0800)
committerH.J. Lu <hjl.tools@gmail.com>
Mon, 13 Nov 2017 01:04:03 +0000 (17:04 -0800)
It was reasonable to mark PT_PHDR segment with PF_X for compatibility
with UnixWare and Solaris linkers 20 years ago.  But it is inappropriate
today when the primary OS of GNU ld is Linux.  This patch removes PF_X
from PT_PHDR segment as gold does.

Tested natively on Linux/x86 as well as crosss-binutils for alpha-linux,
ia64-linux, powerpc64-linux, powerpc-linux, s390-linux, s390x-linux,
sparc64-linux and sparc-linux.

bfd/

PR ld/22423
* elf.c (_bfd_elf_map_sections_to_segments): Remove PF_X from
PT_PHDR segment.

ld/

PR ld/22423
* testsuite/ld-alpha/tlsbin.rd: Replace "R E " with "R +" for
PT_PHDR segment.
* testsuite/ld-alpha/tlsbinr.rd: Likewise.
* testsuite/ld-ia64/tlsbin.rd: Likewise.
* testsuite/ld-powerpc/tlsexe.r: Likewise.
* testsuite/ld-powerpc/tlsexe32.r: Likewise.
* testsuite/ld-powerpc/tlsexetoc.r: Likewise.
* testsuite/ld-s390/tlsbin.rd: Likewise.
* testsuite/ld-s390/tlsbin_64.rd: Likewise.
* testsuite/ld-sparc/tlssunbin32.rd: Likewise.
* testsuite/ld-sparc/tlssunbin64.rd: Likewise.
* testsuite/ld-elf/pr22423.d: New test.

14 files changed:
bfd/ChangeLog patch | blob | history
bfd/elf.c patch | blob | history
ld/ChangeLog patch | blob | history
ld/testsuite/ld-alpha/tlsbin.rd patch | blob | history
ld/testsuite/ld-alpha/tlsbinr.rd patch | blob | history
ld/testsuite/ld-elf/pr22423.d [new file with mode: 0644] patch | blob
ld/testsuite/ld-ia64/tlsbin.rd patch | blob | history
ld/testsuite/ld-powerpc/tlsexe.r patch | blob | history
ld/testsuite/ld-powerpc/tlsexe32.r patch | blob | history
ld/testsuite/ld-powerpc/tlsexetoc.r patch | blob | history
ld/testsuite/ld-s390/tlsbin.rd patch | blob | history
ld/testsuite/ld-s390/tlsbin_64.rd patch | blob | history
ld/testsuite/ld-sparc/tlssunbin32.rd patch | blob | history
ld/testsuite/ld-sparc/tlssunbin64.rd patch | blob | history

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 989149a497387b8cb7e9f935a9f17609edbba87e..d1b995a67f3f98bce88b9c42a04ea91bbad47e32 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2017-11-12  H.J. Lu  <hongjiu.lu@intel.com>
+
+       PR ld/22423
+       * elf.c (_bfd_elf_map_sections_to_segments): Remove PF_X from
+       PT_PHDR segment.
+
 2017-11-12  Alan Modra  <amodra@gmail.com>
 
        * elflink.c (elf_link_add_object_symbols): Ignore anything but
diff --git a/bfd/elf.c b/bfd/elf.c
index 9cecb249221a114d6bcea3e2c6ecf2090abaecc7..694e43540f0cc65c6a955b8434ff445cfe302169 100644 (file)
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -4610,8 +4610,7 @@ _bfd_elf_map_sections_to_segments (bfd *abfd, struct bfd_link_info *info)
            goto error_return;
          m->next = NULL;
          m->p_type = PT_PHDR;
-         /* FIXME: UnixWare and Solaris set PF_X, Irix 5 does not.  */
-         m->p_flags = PF_R | PF_X;
+         m->p_flags = PF_R;
          m->p_flags_valid = 1;
          m->includes_phdrs = 1;
          linker_created_pt_phdr_segment = TRUE;
diff --git a/ld/ChangeLog b/ld/ChangeLog
index 59aff56f6bc9a29b0305216efd6d6625425dba52..5888e052196b4dc3ced1fd64931f06a909273f18 100644 (file)
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,19 @@
+2017-11-12  H.J. Lu  <hongjiu.lu@intel.com>
+
+       PR ld/22423
+       * testsuite/ld-alpha/tlsbin.rd: Replace "R E " with "R +" for
+       PT_PHDR segment.
+       * testsuite/ld-alpha/tlsbinr.rd: Likewise.
+       * testsuite/ld-ia64/tlsbin.rd: Likewise.
+       * testsuite/ld-powerpc/tlsexe.r: Likewise.
+       * testsuite/ld-powerpc/tlsexe32.r: Likewise.
+       * testsuite/ld-powerpc/tlsexetoc.r: Likewise.
+       * testsuite/ld-s390/tlsbin.rd: Likewise.
+       * testsuite/ld-s390/tlsbin_64.rd: Likewise.
+       * testsuite/ld-sparc/tlssunbin32.rd: Likewise.
+       * testsuite/ld-sparc/tlssunbin64.rd: Likewise.
+       * testsuite/ld-elf/pr22423.d: New test.
+
 2017-11-12  H.J. Lu  <hongjiu.lu@intel.com>
 
        * emulparams/elf32_x86_64.sh (TINY_READONLY_SECTION): Renamed
diff --git a/ld/testsuite/ld-alpha/tlsbin.rd b/ld/testsuite/ld-alpha/tlsbin.rd
index 4ce48eafb4a0a8b3a2aad298a940ac6f4db4f2fb..6918611dd384264d76aef9e1aa5c68fc6bdb8023 100644 (file)
--- a/ld/testsuite/ld-alpha/tlsbin.rd
+++ b/ld/testsuite/ld-alpha/tlsbin.rd
@@ -35,7 +35,7 @@ There are [0-9]+ program headers, starting at offset [0-9]+
 
 Program Headers:
   Type +Offset +VirtAddr +PhysAddr +FileSiz +MemSiz +Flg Align
-  PHDR +0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ 0x0+150 R E 0x8
+  PHDR +0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ 0x0+150 R +0x8
   INTERP +0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ R +0x1
 .*Requesting program interpreter.*
   LOAD +0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ R E 0x10000
diff --git a/ld/testsuite/ld-alpha/tlsbinr.rd b/ld/testsuite/ld-alpha/tlsbinr.rd
index 8b7b76a70a3964c39784f29eb91798f25650183f..c3a275f5665bdda89714864d1c3a1731b4ca321c 100644 (file)
--- a/ld/testsuite/ld-alpha/tlsbinr.rd
+++ b/ld/testsuite/ld-alpha/tlsbinr.rd
@@ -35,7 +35,7 @@ There are [0-9]+ program headers, starting at offset [0-9]+
 
 Program Headers:
  +Type +Offset +VirtAddr +PhysAddr +FileSiz +MemSiz +Flg Align
- +PHDR +0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ R E 0x8
+ +PHDR +0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ R +0x8
  +INTERP +0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ R +0x1
 .*Requesting program interpreter.*
  +LOAD +0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ R E 0x10000
diff --git a/ld/testsuite/ld-elf/pr22423.d b/ld/testsuite/ld-elf/pr22423.d
new file mode 100644 (file)
index 0000000..7376302
--- /dev/null
+++ b/ld/testsuite/ld-elf/pr22423.d
@@ -0,0 +1,8 @@
+#source: start.s
+#readelf: -l -W
+#ld: -pie
+#target: *-*-linux* *-*-gnu*
+
+#...
+ +PHDR +0x[0-9a-f]+ +0x[0-9a-f]+ +0x[0-9a-f]+ +0x[0-9a-f]+ +0x[0-9a-f]+ +R +0x[48]?
+#pass
diff --git a/ld/testsuite/ld-ia64/tlsbin.rd b/ld/testsuite/ld-ia64/tlsbin.rd
index 23e24d5079517d386f7f38c13ea7166e5e2bc257..e53367dda7000c9d10114c1b56f17b17d3627800 100644 (file)
--- a/ld/testsuite/ld-ia64/tlsbin.rd
+++ b/ld/testsuite/ld-ia64/tlsbin.rd
@@ -36,7 +36,7 @@ There are [0-9]+ program headers, starting at offset [0-9]+
 
 Program Headers:
  +Type +Offset +VirtAddr +PhysAddr +FileSiz +MemSiz +Flg Align
- +PHDR +0x0+40 0x40+40 0x40+40 0x0+188 0x0+188 R E 0x8
+ +PHDR +0x0+40 0x40+40 0x40+40 0x0+188 0x0+188 R +0x8
  +INTERP +0x0+1c8 0x40+1c8 0x40+1c8 0x[0-9a-f]+ 0x[0-9a-f]+ R +0x1
 .*Requesting program interpreter.*
  +LOAD +0x0+ 0x40+ 0x40+ 0x0+1[0-9a-f]+ 0x0+1[0-9a-f]+ R E 0x10000
diff --git a/ld/testsuite/ld-powerpc/tlsexe.r b/ld/testsuite/ld-powerpc/tlsexe.r
index cc8c79cca53ed871c74a400ee3d12fdcb44323e6..f28ae9c474d20ed9821c971bebf6d17ca403a0aa 100644 (file)
--- a/ld/testsuite/ld-powerpc/tlsexe.r
+++ b/ld/testsuite/ld-powerpc/tlsexe.r
@@ -34,7 +34,7 @@ There are [0-9]+ program headers, starting at offset [0-9]+
 
 Program Headers:
  +Type +Offset +VirtAddr +PhysAddr +FileSiz +MemSiz +Flg Align
- +PHDR +0x0+40 0x0+10000040 0x0+10000040 0x0+150 0x0+150 R E 0x8
+ +PHDR +0x0+40 0x0+10000040 0x0+10000040 0x0+150 0x0+150 R +0x8
  +INTERP +0x0+190 0x0+10000190 0x0+10000190 0x0+11 0x0+11 R +0x1
  +\[Requesting program interpreter: .*\]
  +LOAD .* R E 0x10000
diff --git a/ld/testsuite/ld-powerpc/tlsexe32.r b/ld/testsuite/ld-powerpc/tlsexe32.r
index 2791cf63fcdd60f15b6972972269ffe7fc957f5a..6061835f29c0c7a7b4f4da876508d3d968ab9f5b 100644 (file)
--- a/ld/testsuite/ld-powerpc/tlsexe32.r
+++ b/ld/testsuite/ld-powerpc/tlsexe32.r
@@ -33,7 +33,7 @@ There are [0-9]+ program headers, starting at offset [0-9]+
 
 Program Headers:
  +Type +Offset +VirtAddr +PhysAddr +FileSiz MemSiz +Flg Align
- +PHDR +0x000034 0x01800034 0x01800034 0x000c0 0x000c0 R E 0x4
+ +PHDR +0x000034 0x01800034 0x01800034 0x000c0 0x000c0 R +0x4
  +INTERP +0x0000f4 0x018000f4 0x018000f4 0x00011 0x00011 R +0x1
  +\[Requesting program interpreter: .*\]
  +LOAD .* R E 0x10000
diff --git a/ld/testsuite/ld-powerpc/tlsexetoc.r b/ld/testsuite/ld-powerpc/tlsexetoc.r
index d52a2685a87ee3569d185539bea6021e69120093..ce746d9dce00aed9d1565837c7d4030d09ae76c9 100644 (file)
--- a/ld/testsuite/ld-powerpc/tlsexetoc.r
+++ b/ld/testsuite/ld-powerpc/tlsexetoc.r
@@ -34,7 +34,7 @@ There are [0-9]+ program headers, starting at offset [0-9]+
 
 Program Headers:
  +Type +Offset +VirtAddr +PhysAddr +FileSiz +MemSiz +Flg Align
- +PHDR +0x0+40 0x0+10000040 0x0+10000040 0x0+150 0x0+150 R E 0x8
+ +PHDR +0x0+40 0x0+10000040 0x0+10000040 0x0+150 0x0+150 R +0x8
  +INTERP +0x0+190 0x0+10000190 0x0+10000190 0x0+11 0x0+11 R +0x1
  +\[Requesting program interpreter: .*\]
  +LOAD .* R E 0x10000
diff --git a/ld/testsuite/ld-s390/tlsbin.rd b/ld/testsuite/ld-s390/tlsbin.rd
index 6a97d14b0b2ec7b708d3ea2b444c86f1517bca08..a88b9256e689ec42c1159e6446dd308b8086f756 100644 (file)
--- a/ld/testsuite/ld-s390/tlsbin.rd
+++ b/ld/testsuite/ld-s390/tlsbin.rd
@@ -34,7 +34,7 @@ There are [0-9]+ program headers, starting at offset [0-9]+
 
 Program Headers:
  +Type +Offset +VirtAddr +PhysAddr +FileSiz +MemSiz +Flg Align
- +PHDR +0x0+34 0x0+400034 0x0+400034 0x0+c0 0x0+c0 R E 0x4
+ +PHDR +0x0+34 0x0+400034 0x0+400034 0x0+c0 0x0+c0 R +0x4
  +INTERP +0x0+f4 0x0+4000f4 0x0+4000f4 0x0+d 0x0+d R +0x1
 .*Requesting program interpreter.*
  +LOAD .* R E 0x1000
diff --git a/ld/testsuite/ld-s390/tlsbin_64.rd b/ld/testsuite/ld-s390/tlsbin_64.rd
index 37934bb9eade9b706a0a45a604b9ca9b17b71d46..682f6d7550c31c629f7e1d9bd49b84ab77f10ab6 100644 (file)
--- a/ld/testsuite/ld-s390/tlsbin_64.rd
+++ b/ld/testsuite/ld-s390/tlsbin_64.rd
@@ -34,7 +34,7 @@ There are [0-9]+ program headers, starting at offset [0-9]+
 
 Program Headers:
  +Type +Offset +VirtAddr +PhysAddr +FileSiz +MemSiz +Flg Align
- +PHDR +0x0+40 0x0+1000040 0x0+1000040 0x0+150 0x0+150 R E 0x8
+ +PHDR +0x0+40 0x0+1000040 0x0+1000040 0x0+150 0x0+150 R +0x8
  +INTERP +0x0+190 0x0+1000190 0x0+1000190 0x0+f 0x0+f R +0x1
 .*Requesting program interpreter.*
  +LOAD .* R E 0x1000
diff --git a/ld/testsuite/ld-sparc/tlssunbin32.rd b/ld/testsuite/ld-sparc/tlssunbin32.rd
index 3de615fa569d4f657a64844e253a6c6f25fe2a5b..678a4a1d6e51695f00fb28e509a94c71be1c1618 100644 (file)
--- a/ld/testsuite/ld-sparc/tlssunbin32.rd
+++ b/ld/testsuite/ld-sparc/tlssunbin32.rd
@@ -30,7 +30,7 @@ There are [0-9]+ program headers, starting at offset [0-9]+
 
 Program Headers:
  +Type +Offset +VirtAddr +PhysAddr +FileSiz MemSiz +Flg Align
- +PHDR +0x0+34 0x0+10034 0x0+10034 0x0+c0 0x0+c0 R E 0x4
+ +PHDR +0x0+34 0x0+10034 0x0+10034 0x0+c0 0x0+c0 R +0x4
  +INTERP +0x0+f4 0x0+100f4 0x0+100f4 0x0+11 0x0+11 R +0x1
 .*Requesting program interpreter.*
  +LOAD .* R E 0x10000
diff --git a/ld/testsuite/ld-sparc/tlssunbin64.rd b/ld/testsuite/ld-sparc/tlssunbin64.rd
index 2297d2ecdb8b6926ff97114f336ed6be32c97087..420d5954af264db785ca33276e2e36a16abfd97b 100644 (file)
--- a/ld/testsuite/ld-sparc/tlssunbin64.rd
+++ b/ld/testsuite/ld-sparc/tlssunbin64.rd
@@ -30,7 +30,7 @@ There are [0-9]+ program headers, starting at offset [0-9]+
 
 Program Headers:
  +Type +Offset +VirtAddr +PhysAddr +FileSiz +MemSiz +Flg Align
- +PHDR +0x0+40 0x0+100040 0x0+100040 0x0+150 0x0+150 R E 0x8
+ +PHDR +0x0+40 0x0+100040 0x0+100040 0x0+150 0x0+150 R +0x8
  +INTERP +0x0+190 0x0+100190 0x0+100190 0x0+19 0x0+19 R +0x1
 .*Requesting program interpreter.*
  +LOAD .* R E 0x100000