re PR c++/48113 ([C++0x] bind with tuple argument fails)

	PR c++/48113
	* typeck.c (convert_for_initialization): Use
	perform_implicit_conversion_flags.
	* call.c (standard_conversion): If LOOKUP_PREFER_RVALUE, set
	rvaluedness_matches_p on ck_rvalue.
	(convert_like_real) [ck_rvalue]: And restore it here.

From-SVN: r171067

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 336c22e808c928bb3b0c3a4a4fe840af2d14f930..4649d965ddf4108ce756b5e30111bc1022ba5835 100644 (file)
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,5 +1,12 @@
 2011-03-16  Jason Merrill  <jason@redhat.com>
 
+       PR c++/48113
+       * typeck.c (convert_for_initialization): Use
+       perform_implicit_conversion_flags.
+       * call.c (standard_conversion): If LOOKUP_PREFER_RVALUE, set
+       rvaluedness_matches_p on ck_rvalue.
+       (convert_like_real) [ck_rvalue]: And restore it here.
+
        PR c++/48115
        * call.c (convert_arg_to_ellipsis): Handle incomplete type.
 

diff --git a/gcc/cp/call.c b/gcc/cp/call.c
index f75c2485e31476ea8419698e4b33e87483de5a4b..436c9569d48d2964985f92bc444c9487c3013289 100644 (file)
--- a/gcc/cp/call.c
+++ b/gcc/cp/call.c
@@ -98,7 +98,9 @@ struct conversion {
   BOOL_BITFIELD base_p : 1;
   /* If KIND is ck_ref_bind, true when either an lvalue reference is
      being bound to an lvalue expression or an rvalue reference is
-     being bound to an rvalue expression. */
+     being bound to an rvalue expression.  If KIND is ck_rvalue,
+     true when we should treat an lvalue as an rvalue (12.8p33).  If
+     KIND is ck_base, always false.  */
   BOOL_BITFIELD rvaluedness_matches_p: 1;
   BOOL_BITFIELD check_narrowing: 1;
   /* The type of the expression resulting from the conversion.  */
@@ -897,6 +899,8 @@ standard_conversion (tree to, tree from, tree expr, bool c_cast_p,
            }
        }
       conv = build_conv (ck_rvalue, from, conv);
+      if (flags & LOOKUP_PREFER_RVALUE)
+       conv->rvaluedness_matches_p = true;
     }
 
    /* Allow conversion between `__complex__' data types.  */
@@ -5489,6 +5493,8 @@ convert_like_real (conversion *convs, tree expr, tree fn, int argnum,
           conversion (i.e. the second step of copy-initialization), so
           don't allow any more.  */
        flags |= LOOKUP_NO_CONVERSION;
+      if (convs->rvaluedness_matches_p)
+       flags |= LOOKUP_PREFER_RVALUE;
       if (TREE_CODE (expr) == TARGET_EXPR
          && TARGET_EXPR_LIST_INIT_P (expr))
        /* Copy-list-initialization doesn't actually involve a copy.  */

diff --git a/gcc/cp/typeck.c b/gcc/cp/typeck.c
index c062f0fa5e4d005bb753d02df571522b3504f931..0e8a6d79b3490372d8162b4e8ab9d5d0061c3603 100644 (file)
--- a/gcc/cp/typeck.c
+++ b/gcc/cp/typeck.c
@@ -7454,7 +7454,7 @@ convert_for_initialization (tree exp, tree type, tree rhs, int flags,
     return rhs;
 
   if (MAYBE_CLASS_TYPE_P (type))
-    return ocp_convert (type, rhs, CONV_IMPLICIT|CONV_FORCE_TEMP, flags);
+    return perform_implicit_conversion_flags (type, rhs, complain, flags);
 
   return convert_for_assignment (type, rhs, errtype, fndecl, parmnum,
                                 complain, flags);

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index ca82c7409c7547f40ef8bfa87c04801fd4277edd..dee4a8d4aa0ae57b650cfe404a7e95757a676dee 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,12 @@
+2011-03-16  Jason Merrill  <jason@redhat.com>
+
+       * g++.dg/cpp0x/sfinae6.C: New.
+       * gcc/testsuite/g++.dg/cpp0x/initlist38.C: Adjust expected error.
+       * gcc/testsuite/g++.dg/cpp0x/pr45908.C: Likewise.
+       * gcc/testsuite/g++.dg/cpp0x/sfinae6.C: Likewise.
+       * gcc/testsuite/g++.old-deja/g++.jason/conversion11.C: Likewise.
+       * gcc/testsuite/g++.old-deja/g++.law/arg11.C: Likewise.
+
 2011-03-16  Jason Merrill  <jason@redhat.com>
 
        * g++.dg/template/incomplete6.C: New.

diff --git a/gcc/testsuite/g++.dg/cpp0x/initlist38.C b/gcc/testsuite/g++.dg/cpp0x/initlist38.C
index 818d69ad654acb0b1476880efc95d36960dcc1ab..32e20d591c7ff3f58ab91e882d6b41710b983f7d 100644 (file)
--- a/gcc/testsuite/g++.dg/cpp0x/initlist38.C
+++ b/gcc/testsuite/g++.dg/cpp0x/initlist38.C
@@ -17,5 +17,5 @@ int main()
   f({});
   B b0 = { };
   B b1 { };    // OK, uses #1
-  B b2 { 1 };  // { dg-error "conversion" }
+  B b2 { 1 };  // { dg-error "could not convert" }
 }

diff --git a/gcc/testsuite/g++.dg/cpp0x/pr45908.C b/gcc/testsuite/g++.dg/cpp0x/pr45908.C
index 1a821e5d83b46ebe2cac7b62d26daca4718b48ca..3a8508890ee1839a347e5cc28b14698513caa31d 100644 (file)
--- a/gcc/testsuite/g++.dg/cpp0x/pr45908.C
+++ b/gcc/testsuite/g++.dg/cpp0x/pr45908.C
@@ -14,5 +14,5 @@ struct vector {
 class block {
     vector v;
     auto end() const -> decltype(v.begin())
-    { return v.begin(); } // { dg-error "conversion" }
+    { return v.begin(); } // { dg-error "could not convert" }
 };

diff --git a/gcc/testsuite/g++.dg/cpp0x/sfinae6.C b/gcc/testsuite/g++.dg/cpp0x/sfinae6.C
new file mode 100644 (file)
index 0000000..401d536
--- /dev/null
+++ b/gcc/testsuite/g++.dg/cpp0x/sfinae6.C
@@ -0,0 +1,31 @@
+// PR c++/48113
+// { dg-options -std=c++0x }
+
+template<typename T> T declval();
+
+struct tuple { };
+
+struct F1
+{
+    void operator()(tuple, int);
+};
+
+typedef void (*F2)(tuple, int);
+
+template<typename F, typename T>
+struct Bind
+{
+    template<typename A,
+             typename R = decltype( F()(declval<T&>(), A()) )>
+    R f(A);
+
+    template<typename A,
+             typename R = decltype( F()(declval<volatile T&>(), A()) )>
+    R f(A) volatile;
+};
+
+int main()
+{
+    Bind<F1, tuple>().f(0);  // OK
+    Bind<F2, tuple>().f(0);  // ERROR, should be OK
+}

diff --git a/gcc/testsuite/g++.old-deja/g++.jason/conversion11.C b/gcc/testsuite/g++.old-deja/g++.jason/conversion11.C
index 607cf9cc841b0b42d3eeb40c2dc0f5728193be7a..6621a27b6a2cbcb8717e4439b3eb2df9851d3c54 100644 (file)
--- a/gcc/testsuite/g++.old-deja/g++.jason/conversion11.C
+++ b/gcc/testsuite/g++.old-deja/g++.jason/conversion11.C
@@ -21,7 +21,7 @@ void DoSomething(Ding A);
 
 void foo(Something* pX)
 {
-  DoSomething(1);              // { dg-error "conversion" } 
+  DoSomething(1);              // { dg-error "could not convert" }
   pX->DoSomething(1);          // { dg-error "no matching" } 
   // { dg-message "candidate" "candidate note" { target *-*-* } 25 }
   (*pX).DoSomething(1);                // { dg-error "no matching" } 

diff --git a/gcc/testsuite/g++.old-deja/g++.law/arg11.C b/gcc/testsuite/g++.old-deja/g++.law/arg11.C
index fc590c4387a13a3f6ded28b36b9edf9690e987dc..fc9357964f497215c211aa968d7245ad8d7722d1 100644 (file)
--- a/gcc/testsuite/g++.old-deja/g++.law/arg11.C
+++ b/gcc/testsuite/g++.old-deja/g++.law/arg11.C
@@ -16,7 +16,7 @@ void function(Ack);
 int
 foo(S *o)
 { // Neither call has a usable constructor for conversions of char[5] to Ack.
-  function("adsf");// { dg-error "conversion" } 
+  function("adsf");// { dg-error "could not convert" }
   o->method("adsf");// { dg-error "no matching" } 
   // { dg-message "candidate" "candidate note" { target *-*-* } 20 }
   return 0;