2007-08-02 Michael Snyder <msnyder@access-company.com>

	* gdbtypes.c (create_set_type): Test should only be done within
	the preceeding if block.  Otherwise, variable is uninitialized.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d462a310cd6bce784e931e9165c1cad0dac0f060..5aaee7ab1600f3ebd9ed6f1fa379987d4f77ff2a 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,8 @@
 2007-08-02  Michael Snyder  <msnyder@access-company.com>
 
+       * gdbtypes.c (create_set_type): Test should only be done within
+       the preceeding if block.  Otherwise, variable is uninitialized.
+
        * gdbtypes.c (check_typedef): Guard NULL.
 
 2007-08-01  Michael Snyder  <msnyder@access-company.com>

diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
index 994178d5179fb3cf3fe2a87f48ef48b9d320fbdf..887f40007f4a7911bfbe1ebd69ff087ee1c0b777 100644 (file)
--- a/gdb/gdbtypes.c
+++ b/gdb/gdbtypes.c
@@ -843,7 +843,6 @@ create_string_type (struct type *result_type, struct type *range_type)
 struct type *
 create_set_type (struct type *result_type, struct type *domain_type)
 {
-  LONGEST low_bound, high_bound, bit_length;
   if (result_type == NULL)
     {
       result_type = alloc_type (TYPE_OBJFILE (domain_type));
@@ -856,17 +855,17 @@ create_set_type (struct type *result_type, struct type *domain_type)
 
   if (!TYPE_STUB (domain_type))
     {
+      LONGEST low_bound, high_bound, bit_length;
       if (get_discrete_bounds (domain_type, &low_bound, &high_bound) < 0)
        low_bound = high_bound = 0;
       bit_length = high_bound - low_bound + 1;
       TYPE_LENGTH (result_type)
        = (bit_length + TARGET_CHAR_BIT - 1) / TARGET_CHAR_BIT;
+      if (low_bound >= 0)
+       TYPE_FLAGS (result_type) |= TYPE_FLAG_UNSIGNED;
     }
   TYPE_FIELD_TYPE (result_type, 0) = domain_type;
 
-  if (low_bound >= 0)
-    TYPE_FLAGS (result_type) |= TYPE_FLAG_UNSIGNED;
-
   return (result_type);
 }