i965/fs: Improve a comment about stripping trailing zeroes
authorNeil Roberts <neil@linux.intel.com>
Fri, 8 May 2015 15:13:52 +0000 (16:13 +0100)
committerNeil Roberts <neil@linux.intel.com>
Fri, 8 May 2015 15:16:56 +0000 (16:16 +0100)
Originally I wrote that removing the first parameter doesn't work but
I didn't know why. I now found a mention of this in the PRM so it's
probably worthing adding it to the comment.

src/mesa/drivers/dri/i965/brw_fs.cpp

index 8dd680e1ae34839c648b2e9ec5b1d4de03627132..b2701b896892e5c0bb3de6c8edddd2f463273367 100644 (file)
@@ -2600,9 +2600,12 @@ fs_visitor::opt_zero_samples()
           load_payload->opcode != SHADER_OPCODE_LOAD_PAYLOAD)
          continue;
 
-      /* We don't want to remove the message header. Removing all of the
-       * parameters is avoided because it seems to cause a GPU hang but I
-       * can't find any documentation indicating that this is expected.
+      /* We don't want to remove the message header or the first parameter.
+       * Removing the first parameter is not allowed, see the Haswell PRM
+       * volume 7, page 149:
+       *
+       *     "Parameter 0 is required except for the sampleinfo message, which
+       *      has no parameter 0"
        */
       while (inst->mlen > inst->header_size + dispatch_width / 8 &&
              load_payload->src[(inst->mlen - inst->header_size) /