compiler: export thunks referenced by inline functions
authorIan Lance Taylor <iant@golang.org>
Fri, 14 Aug 2020 22:27:15 +0000 (15:27 -0700)
committerIan Lance Taylor <iant@golang.org>
Mon, 17 Aug 2020 23:32:53 +0000 (16:32 -0700)
The test case is https://golang.org/cl/248637.

Fixes golang/go#40252

Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/248638

gcc/go/gofrontend/MERGE
gcc/go/gofrontend/expressions.cc
gcc/go/gofrontend/gogo.cc

index e443282d0e842562a85a0e920bf8285233181df9..e425f15285eaa4a83786412270f51924d68ec582 100644 (file)
@@ -1,4 +1,4 @@
-fe5d94c5792f7f990004c3dee0ea501835512200
+823c91088bc6ac606362fc34b2880ce0de1624ad
 
 The first line of this file holds the git revision number of the last
 merge done from the gofrontend repository.
index d295fd10136aa2b6da9eb819841d5fa5f56bd0bc..8bbc557c65ffbafeb1b447eb0870a4fb9e482379 100644 (file)
@@ -1635,16 +1635,15 @@ Func_descriptor_expression::do_get_backend(Translate_context* context)
              || no->name().find("equal") != std::string::npos))
        is_exported_runtime = true;
 
-      bool is_referenced_by_inline =
-       no->is_function() && no->func_value()->is_referenced_by_inline();
-
       bool is_hidden = ((no->is_function()
                         && no->func_value()->enclosing() != NULL)
                        || (Gogo::is_hidden_name(no->name())
-                           && !is_exported_runtime
-                           && !is_referenced_by_inline)
+                           && !is_exported_runtime)
                        || Gogo::is_thunk(no));
 
+      if (no->is_function() && no->func_value()->is_referenced_by_inline())
+       is_hidden = false;
+
       bvar = context->backend()->immutable_struct(var_name, asm_name,
                                                   is_hidden, false,
                                                  btype, bloc);
index 13de74bc8700e263f120c45c159f6f654aec7eef..82d4c1fd54d5b1729a1ff36eba8d85413a8b749f 100644 (file)
@@ -3370,7 +3370,8 @@ class Create_function_descriptors : public Traverse
   Gogo* gogo_;
 };
 
-// Create a descriptor for every top-level exported function.
+// Create a descriptor for every top-level exported function and every
+// function referenced by an inline function.
 
 int
 Create_function_descriptors::function(Named_object* no)
@@ -3378,8 +3379,9 @@ Create_function_descriptors::function(Named_object* no)
   if (no->is_function()
       && no->func_value()->enclosing() == NULL
       && !no->func_value()->is_method()
-      && !Gogo::is_hidden_name(no->name())
-      && !Gogo::is_thunk(no))
+      && ((!Gogo::is_hidden_name(no->name())
+          && !Gogo::is_thunk(no))
+         || no->func_value()->is_referenced_by_inline()))
     no->func_value()->descriptor(this->gogo_, no);
 
   return TRAVERSE_CONTINUE;