r300: Take care of some XXXes.
authorCorbin Simpson <MostAwesomeDude@gmail.com>
Tue, 3 Feb 2009 00:13:41 +0000 (16:13 -0800)
committerCorbin Simpson <MostAwesomeDude@gmail.com>
Tue, 3 Feb 2009 00:13:41 +0000 (16:13 -0800)
src/gallium/drivers/r300/r300_chipset.c
src/gallium/drivers/r300/r300_screen.c
src/gallium/drivers/r300/r300_winsys.h

index 4c84be26efa19beeee7ba2d2fe379166ec279fa7..b0a7fe7d213954278276c5cf0944681d08b4c8d2 100644 (file)
@@ -337,7 +337,8 @@ void r300_parse_chipset(struct r300_capabilities* caps)
             break;
 
         default:
-            /* XXX not an r300?! */
+            debug_printf("r300: Warning: Unknown chipset 0x%x\n",
+                caps->pci_id);
             break;
     }
 
index 99dcf38f43103a9b92e8ec59e49397b504c14bd9..8e77e0ddd977599d83d3eb876a2dc495ee1a9f69 100644 (file)
@@ -81,12 +81,11 @@ static int r300_get_param(struct pipe_screen* pscreen, int param)
             /* IN THEORY */
             return 0;
         case PIPE_CAP_TWO_SIDED_STENCIL:
-            /* IN THEORY */
-            /* if (r300screen->is_r500) {
-             * return 1;
-             * } else {
-             * return 0;
-             * } */
+            if (r300screen->is_r500) {
+                return 1;
+            } else {
+                return 0;
+            }
             return 0;
         case PIPE_CAP_GLSL:
             /* IN THEORY */
index 867d65b7de136915bd2b85f74d936692f5f427bb..5a3a2128927f681434772b5ebadd5fa324d9921c 100644 (file)
@@ -64,7 +64,6 @@ struct r300_winsys {
            int line);
 
     /* Write a dword to the command buffer. */
-    /* XXX is this an okay name for this handle? */
     void (*write_cs_dword)(struct radeon_cs* cs, uint32_t dword);
 
     /* Write a relocated dword to the command buffer. */