Fix interp::m_name resource leak found by Coverity

This commit fixes a resource leak found by Coverity, where interp's
constructor allocated memory for m_name that interp's destructor did
not free.

gdb/ChangeLog:

	* interps.h (interp::m_name): Make private and mutable.
	* interps.c (interp::~interp): Free m_name.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e28b464f207fc743ab3f238ba84f1fe08369fd80..b3cc64659fe318ad21dfe98cf5c5f7dee2e435d4 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2018-10-11  Gary Benson <gbenson@redhat.com>
+
+       * interps.h (interp::m_name): Make private and mutable.
+       * interps.c (interp::~interp): Free m_name.
+
 2018-10-10  Sergio Durigan Junior  <sergiodj@redhat.com>
            Simon Marchi <simark@simark.ca>
 

diff --git a/gdb/interps.c b/gdb/interps.c
index 6fe4c74e938616139d6c579fb1e2a3fdb16f1d38..883e0426a31fdfad9a2a16608b3d68dc86571bb9 100644 (file)
--- a/gdb/interps.c
+++ b/gdb/interps.c
@@ -84,7 +84,9 @@ interp::interp (const char *name)
 }
 
 interp::~interp ()
-{}
+{
+  xfree (m_name);
+}
 
 /* An interpreter factory.  Maps an interpreter name to the factory
    function that instantiates an interpreter by that name.  */

diff --git a/gdb/interps.h b/gdb/interps.h
index 74c9a80918c7ae602053d95c6ca7f112884d3bbb..dbf91f18e8327b57a5d3f35623995291f7fbe353 100644 (file)
--- a/gdb/interps.h
+++ b/gdb/interps.h
@@ -80,10 +80,12 @@ public:
   }
 
   /* This is the name in "-i=" and "set interpreter".  */
-  const char *m_name;
+private:
+  char *m_name;
 
   /* Interpreters are stored in a linked list, this is the next
      one...  */
+public:
   struct interp *next;
 
   /* Has the init method been run?  */