re PR target/89093 (C++ exception handling clobbers d8 VFP register)

	PR target/89093
	* config/arm/arm.c (arm_valid_target_attribute_rec): Don't skip
	whitespace at the start of target attribute string.

	* gcc.target/arm/pr89093-2.c: New test.

From-SVN: r270404

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 437159728a234420c3a3d13d43b03329778e8c29..231bb83c4f3f4cfda68e15899f6a72b2a73c44b0 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2019-04-17  Jakub Jelinek  <jakub@redhat.com>
+
+       PR target/89093
+       * config/arm/arm.c (arm_valid_target_attribute_rec): Don't skip
+       whitespace at the start of target attribute string.
+
 2019-04-16  Pat Haugen  <pthaugen@us.ibm.com>
 
        PR target/84369

diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c
index 9cda96ae84a2749105dd456d67726071368f2591..731150d7c18f2f4168a292a3e4c6dc74ad415075 100644 (file)
--- a/gcc/config/arm/arm.c
+++ b/gcc/config/arm/arm.c
@@ -30871,8 +30871,6 @@ arm_valid_target_attribute_rec (tree args, struct gcc_options *opts)
 
   while ((q = strtok (argstr, ",")) != NULL)
     {
-      while (ISSPACE (*q)) ++q;
-
       argstr = NULL;
       if (!strcmp (q, "thumb"))
        opts->x_target_flags |= MASK_THUMB;

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 6abbc572ded4c0768a7b3102ec3155c84a7439c5..23f77ec781a694ffd7b62143828d23af5cfe8e25 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2019-04-17  Jakub Jelinek  <jakub@redhat.com>
+
+       PR target/89093
+       * gcc.target/arm/pr89093-2.c: New test.
+
 2019-04-16  Jakub Jelinek  <jakub@redhat.com>
 
        PR c++/86953

diff --git a/gcc/testsuite/gcc.target/arm/pr89093-2.c b/gcc/testsuite/gcc.target/arm/pr89093-2.c
new file mode 100644 (file)
index 0000000..08de748
--- /dev/null
+++ b/gcc/testsuite/gcc.target/arm/pr89093-2.c
@@ -0,0 +1,9 @@
+/* PR target/89093 */
+/* { dg-do compile } */
+
+__attribute__((target (" arm"))) void f1 (void) {} /* { dg-error "unknown target attribute or pragma ' arm'" } */
+__attribute__((target ("   thumb"))) void f2 (void) {} /* { dg-error "unknown target attribute or pragma '   thumb'" } */
+__attribute__((target ("arm,  thumb"))) void f3 (void) {} /* { dg-error "unknown target attribute or pragma '  thumb'" } */
+__attribute__((target ("thumb,  arm"))) void f4 (void) {} /* { dg-error "unknown target attribute or pragma '  arm'" } */
+#pragma GCC target ("    arm") /* { dg-error "unknown target attribute or pragma '    arm'" } */
+void f5 (void) {}