elf32-csky.c:3932:19: error: comparison is always false

It looks like csky missed out on an edit for 706704c8834.  Not that it
matters very much.  There doesn't appear to be any csky reloc howto
that sets the negate bit.

Similarly for ns32k and nds32.

	* elf32-csky.c (csky_relocate_contents): Correct negate test.
	* cpu-ns32k.c (_bfd_do_ns32k_reloc_contents): Likewise.
	* elf32-nds32.c (nds32_relocate_contents): Likewise.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 1cf06249f3e50ac95fd3cce5251b5c8e752417af..8a32d5c0102909bebadc3601003b423f6ab6571e 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2020-12-07  Alan Modra  <amodra@gmail.com>
+
+       * elf32-csky.c (csky_relocate_contents): Correct negate test.
+       * cpu-ns32k.c (_bfd_do_ns32k_reloc_contents): Likewise.
+       * elf32-nds32.c (nds32_relocate_contents): Likewise.
+
 2020-12-05  Maciej W. Rozycki  <macro@linux-mips.org>
 
        * elf32-vax.c (elf_vax_check_relocs) <R_VAX_GOT32>: Use

diff --git a/bfd/cpu-ns32k.c b/bfd/cpu-ns32k.c
index 789e56f4b5a817e3128f3d0a2f90546fab94cde9..a7aa9f5df8a752789f08fbe48ebfd544f52f65c9 100644 (file)
--- a/bfd/cpu-ns32k.c
+++ b/bfd/cpu-ns32k.c
@@ -574,9 +574,7 @@ _bfd_do_ns32k_reloc_contents (reloc_howto_type *howto,
   bfd_vma x;
   bfd_boolean overflow;
 
-  /* If the size is negative, negate RELOCATION.  This isn't very
-     general.  */
-  if (howto->size < 0)
+  if (howto->negate)
     relocation = -relocation;
 
   /* Get the value we are going to relocate.  */

diff --git a/bfd/elf32-csky.c b/bfd/elf32-csky.c
index 395e6ff67f9b9e3ebcf93ceba09543380cff7e44..8d48a03aadff15afa60031e04618bbcc343ed8b1 100644 (file)
--- a/bfd/elf32-csky.c
+++ b/bfd/elf32-csky.c
@@ -3927,9 +3927,7 @@ csky_relocate_contents (reloc_howto_type *howto,
   unsigned int rightshift = howto->rightshift;
   unsigned int bitpos = howto->bitpos;
 
-  /* If the size is negative, negate RELOCATION. This isn't very
-     general.  */
-  if (howto->size < 0)
+  if (howto->negate)
     relocation = -relocation;
 
   /* FIXME: these macros should be defined at file head or head file head.  */

diff --git a/bfd/elf32-nds32.c b/bfd/elf32-nds32.c
index 233af38c2307e1c66dc02d8d5d2cb966e2293420..105d7f5d4ec9e6bcb993323f56ed91be4b52d280 100644 (file)
--- a/bfd/elf32-nds32.c
+++ b/bfd/elf32-nds32.c
@@ -4492,9 +4492,7 @@ nds32_relocate_contents (reloc_howto_type *howto, bfd *input_bfd,
   unsigned int rightshift = howto->rightshift;
   unsigned int bitpos = howto->bitpos;
 
-  /* If the size is negative, negate RELOCATION.  This isn't very
-     general.  */
-  if (howto->size < 0)
+  if (howto->negate)
     relocation = -relocation;
 
   /* Get the value we are going to relocate.  */