Remove some dead code.
authorMorgan Deters <mdeters@cs.nyu.edu>
Fri, 7 Nov 2014 23:59:36 +0000 (18:59 -0500)
committerMorgan Deters <mdeters@cs.nyu.edu>
Fri, 7 Nov 2014 23:59:36 +0000 (18:59 -0500)
src/Makefile.am
src/prop/bvminisat/bvminisat.h
src/prop/minisat/minisat.h
src/prop/options
src/prop/options_handlers.h [deleted file]
src/prop/sat_solver_factory.cpp
src/prop/sat_solver_factory.h
src/prop/sat_solver_registry.cpp [deleted file]
src/prop/sat_solver_registry.h [deleted file]

index a04b86bee69cc5d1668fb820ee23cb2ec501baf7..2acefc5777c603c6b85a12b5aa66c5e14969841b 100644 (file)
@@ -100,9 +100,6 @@ libcvc4_la_SOURCES = \
        prop/sat_solver_types.h \
        prop/sat_solver_factory.h \
        prop/sat_solver_factory.cpp \
-       prop/sat_solver_registry.h \
-       prop/sat_solver_registry.cpp \
-       prop/options_handlers.h \
        smt/smt_engine.cpp \
        smt/smt_engine_check_proof.cpp \
        smt/smt_engine.h \
index c7ee2e0b70838f11221d87cfd4691a82c05ed3a6..fea437565e48ae36922c2fce791ee884246c998a 100644 (file)
@@ -21,7 +21,6 @@
 #pragma once
 
 #include "prop/sat_solver.h"
-#include "prop/sat_solver_registry.h"
 #include "prop/bvminisat/simp/SimpSolver.h"
 #include "context/cdo.h"
 
index 3d3cea356a14263720868b3b2515383a3f31d839..96893fe41bc4451d22c7994123ba2afeb314a5f5 100644 (file)
@@ -19,7 +19,6 @@
 #pragma once
 
 #include "prop/sat_solver.h"
-#include "prop/sat_solver_registry.h"
 #include "prop/minisat/simp/SimpSolver.h"
 
 namespace CVC4 {
index 71091d2b539601f353cc4ff54bc5133b68b3b27b..8189d61f8e3bae5999a6b60578c5cfe474bc2ac6 100644 (file)
@@ -5,9 +5,6 @@
 
 module PROP "prop/options.h" SAT layer
 
-option - --show-sat-solvers void :handler CVC4::prop::showSatSolvers :handler-include "prop/options_handlers.h"
- show all available SAT solvers
-
 option satRandomFreq random-frequency --random-freq=P double :default 0.0 :predicate greater_equal(0.0) less_equal(1.0)
  sets the frequency of random decisions in the sat solver (P=0.0 by default)
 option satRandomSeed random-seed --random-seed=S uint32_t :default 0 :read-write
diff --git a/src/prop/options_handlers.h b/src/prop/options_handlers.h
deleted file mode 100644 (file)
index 8ed53a3..0000000
+++ /dev/null
@@ -1,47 +0,0 @@
-/*********************                                                        */
-/*! \file options_handlers.h
- ** \verbatim
- ** Original author: Morgan Deters
- ** Major contributors: none
- ** Minor contributors (to current version): none
- ** This file is part of the CVC4 project.
- ** Copyright (c) 2009-2014  New York University and The University of Iowa
- ** See the file COPYING in the top-level source directory for licensing
- ** information.\endverbatim
- **
- ** \brief [[ Add one-line brief description here ]]
- **
- ** [[ Add lengthier description here ]]
- ** \todo document this file
- **/
-
-#include "cvc4_private.h"
-
-#ifndef __CVC4__PROP__OPTIONS_HANDLERS_H
-#define __CVC4__PROP__OPTIONS_HANDLERS_H
-
-#include "prop/sat_solver_factory.h"
-#include <string>
-#include <vector>
-
-namespace CVC4 {
-namespace prop {
-
-inline void showSatSolvers(std::string option, SmtEngine* smt) {
-  std::vector<std::string> solvers;
-  SatSolverFactory::getSolverIds(solvers);
-  printf("Available SAT solvers: ");
-  for (unsigned i = 0; i < solvers.size(); ++ i) {
-    if (i > 0) {
-      printf(", ");
-    }
-    printf("%s", solvers[i].c_str());
-  }
-  printf("\n");
-  exit(0);
-}
-
-}/* CVC4::prop namespace */
-}/* CVC4 namespace */
-
-#endif /* __CVC4__PROP__OPTIONS_HANDLERS_H */
index 3d3e76205b443d2ea9782aaae6b4cde0ff324988..98b8fce4749c8f21bd8bc0f0b1cc762ba1841eb1 100644 (file)
  **/
 
 #include "prop/sat_solver_factory.h"
-#include "prop/sat_solver_registry.h"
 #include "prop/minisat/minisat.h"
 #include "prop/bvminisat/bvminisat.h"
 
 namespace CVC4 {
 namespace prop {
 
-template class SatSolverConstructor<MinisatSatSolver>;
-template class SatSolverConstructor<BVMinisatSatSolver>;
-
 BVSatSolverInterface* SatSolverFactory::createMinisat(context::Context* mainSatContext, const std::string& name) {
   return new BVMinisatSatSolver(mainSatContext, name);
 }
@@ -33,18 +29,5 @@ DPLLSatSolverInterface* SatSolverFactory::createDPLLMinisat() {
   return new MinisatSatSolver();
 }
 
-SatSolver* SatSolverFactory::create(const char* name) {
-  SatSolverConstructorInterface* constructor = SatSolverRegistry::getConstructor(name);
-  if (constructor) {
-    return constructor->construct();
-  } else {
-    return NULL;
-  }
-}
-
-void SatSolverFactory::getSolverIds(std::vector<std::string>& solvers) {
-  SatSolverRegistry::getSolverIds(solvers);
-}
-
 } /* CVC4::prop namespace */
 } /* CVC4 namespace */
index 0096222124acd5d0b4829f9b48f1f33bb106eb68..34776c24561273f2673e477b31a7e5fa39965454 100644 (file)
@@ -31,11 +31,6 @@ public:
   static BVSatSolverInterface* createMinisat(context::Context* mainSatContext, const std::string& name = "");
   static DPLLSatSolverInterface* createDPLLMinisat();
 
-  static SatSolver* create(const char* id);
-
-  /** Get the solver ids that are available */
-  static void getSolverIds(std::vector<std::string>& solvers);
-
 };/* class SatSolverFactory */
 
 }/* CVC4::prop namespace */
diff --git a/src/prop/sat_solver_registry.cpp b/src/prop/sat_solver_registry.cpp
deleted file mode 100644 (file)
index 5cf7969..0000000
+++ /dev/null
@@ -1,60 +0,0 @@
-/*********************                                                        */
-/*! \file sat_solver_registry.cpp
- ** \verbatim
- ** Original author: Dejan Jovanovic
- ** Major contributors: none
- ** Minor contributors (to current version): Morgan Deters
- ** This file is part of the CVC4 project.
- ** Copyright (c) 2009-2014  New York University and The University of Iowa
- ** See the file COPYING in the top-level source directory for licensing
- ** information.\endverbatim
- **
- ** \brief This class transforms a sequence of formulas into clauses.
- **
- ** This class takes a sequence of formulas.
- ** It outputs a stream of clauses that is propositionally
- ** equi-satisfiable with the conjunction of the formulas.
- ** This stream is maintained in an online fashion.
- **
- ** Compile time registration of SAT solvers with the SAT solver factory
- **/
-
-#include "prop/sat_solver_registry.h"
-#include "sstream"
-
-using namespace std;
-using namespace CVC4;
-using namespace prop;
-
-SatSolverConstructorInterface* SatSolverRegistry::getConstructor(string id) {
-  SatSolverRegistry* registry = getInstance();
-  registry_type::const_iterator find = registry->d_solvers.find(id);
-  if (find == registry->d_solvers.end()) {
-    return NULL;
-  } else {
-    return find->second;
-  }
-}
-
-void SatSolverRegistry::getSolverIds(std::vector<std::string>& solvers) {
-  SatSolverRegistry* registry = getInstance();
-  registry_type::const_iterator it = registry->d_solvers.begin();
-  registry_type::const_iterator it_end = registry->d_solvers.end();
-  for (; it != it_end; ++ it) {
-    solvers.push_back(it->first);
-  }
-}
-
-SatSolverRegistry* SatSolverRegistry::getInstance() {
-  static SatSolverRegistry registry;
-  return &registry;
-}
-
-SatSolverRegistry::~SatSolverRegistry() {
-  registry_type::const_iterator it = d_solvers.begin();
-  registry_type::const_iterator it_end = d_solvers.end();
-  for (; it != it_end; ++ it) {
-    delete it->second;
-  }
-  d_solvers.clear();
-}
diff --git a/src/prop/sat_solver_registry.h b/src/prop/sat_solver_registry.h
deleted file mode 100644 (file)
index 7a326d6..0000000
+++ /dev/null
@@ -1,115 +0,0 @@
-/*********************                                                        */
-/*! \file sat_solver_registry.h
- ** \verbatim
- ** Original author: Dejan Jovanovic
- ** Major contributors: none
- ** Minor contributors (to current version): Morgan Deters
- ** This file is part of the CVC4 project.
- ** Copyright (c) 2009-2014  New York University and The University of Iowa
- ** See the file COPYING in the top-level source directory for licensing
- ** information.\endverbatim
- **
- ** \brief This class transforms a sequence of formulas into clauses.
- **
- ** This class takes a sequence of formulas.
- ** It outputs a stream of clauses that is propositionally
- ** equi-satisfiable with the conjunction of the formulas.
- ** This stream is maintained in an online fashion.
- **
- ** Compile time registration of SAT solvers with the SAT solver factory
- **/
-
-#pragma once
-
-#include "cvc4_private.h"
-
-#include <map>
-#include <string>
-#include <cxxabi.h>
-#include "prop/sat_solver.h"
-#include "prop/sat_solver_factory.h"
-
-namespace CVC4 {
-namespace prop {
-
-/**
- * Interface for SAT solver constructors. Solvers should declare an instantiation of the
- * SatSolverConstructor interface below.
- */
-class SatSolverConstructorInterface {
-public:
-  virtual ~SatSolverConstructorInterface() {}
-  virtual SatSolver* construct() = 0;
-};
-
-/**
- * Registry containing all the registered SAT solvers.
- */
-class SatSolverRegistry {
-
-  typedef std::map<std::string, SatSolverConstructorInterface*> registry_type;
-
-  /** Map from ids to solver constructors */
-  registry_type d_solvers;
-
-  /** Nobody can create the registry, there can be only one! */
-  SatSolverRegistry() {}
-
-  /**
-   * Register a SAT solver with the registry. The Constructor type should be a subclass
-   * of the SatSolverConstructor.
-   */
-  template <typename Constructor>
-  size_t registerSolver(const char* id) {
-    int status;
-    char* demangled = abi::__cxa_demangle(id, 0, 0, &status);
-    d_solvers[demangled] = new Constructor();
-    free(demangled);
-    return d_solvers.size();
-  }
-
-  /** Get the instance of the registry */
-  static SatSolverRegistry* getInstance();
-
-public:
-
-  /** Destructor */
-  ~SatSolverRegistry();
-
-  /**
-   * Returns the constructor for the given SAT solver.
-   */
-  static SatSolverConstructorInterface* getConstructor(std::string id);
-
-  /** Get the ids of the available solvers */
-  static void getSolverIds(std::vector<std::string>& solvers);
-
-  /** The Constructors are friends, since they need to register */
-  template<typename Solver>
-  friend class SatSolverConstructor;
-
-};
-
-/**
- * Declare an instance of this class with the SAT solver in order to put it in the registry.
- */
-template<typename Solver>
-class SatSolverConstructor : public SatSolverConstructorInterface {
-
-  /** Static solver id we use for initialization */
-  static const size_t s_solverId;
-
-public:
-
-  /** Constructs the solver */
-  SatSolver* construct() {
-    return new Solver();
-  }
-
-};
-
-template<typename Solver>
-const size_t SatSolverConstructor<Solver>::s_solverId = SatSolverRegistry::getInstance()->registerSolver<SatSolverConstructor>(typeid(Solver).name());
-
-}/* CVC4::prop namespace */
-}/* CVC4 namespace */