match.pd: Simplify unsigned A - B - 1 >= A to B >= A [PR94913]

Implemented thusly.  The TYPE_OVERFLOW_WRAPS is there just because the
pattern above it has it too, if you want, I can throw it away from both.

2020-05-08  Jakub Jelinek  <jakub@redhat.com>

	PR tree-optimization/94913
	* match.pd (A - B + -1 >= A to B >= A): New simplification.
	(A - B > A to A < B): Don't test TYPE_OVERFLOW_WRAPS which is always
	true for TYPE_UNSIGNED integral types.

	* gcc.dg/tree-ssa/pr94913.c: New test.

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 27f6ea4f97f39ebbd551ed141e7cdfff1fe1a480..eb4924a3b4ba13e20f8b11481eada9d3fc572547 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,5 +1,10 @@
 2020-05-08  Jakub Jelinek  <jakub@redhat.com>
 
+       PR tree-optimization/94913
+       * match.pd (A - B + -1 >= A to B >= A): New simplification.
+       (A - B > A to A < B): Don't test TYPE_OVERFLOW_WRAPS which is always
+       true for TYPE_UNSIGNED integral types.
+
        PR bootstrap/94961
        PR rtl-optimization/94516
        * rtl.h (remove_reg_equal_equiv_notes): Add a bool argument defaulted

diff --git a/gcc/match.pd b/gcc/match.pd
index 9259dd4ddaa1dec50a53146401680e4349f82d00..cfe96975d8054196df302feaba041205ecb21b2a 100644 (file)
--- a/gcc/match.pd
+++ b/gcc/match.pd
@@ -4787,10 +4787,17 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT)
   (cmp:c (minus@2 @0 @1) @0)
   (if (single_use (@2)
        && ANY_INTEGRAL_TYPE_P (TREE_TYPE (@0))
-       && TYPE_UNSIGNED (TREE_TYPE (@0))
-       && TYPE_OVERFLOW_WRAPS (TREE_TYPE (@0)))
+       && TYPE_UNSIGNED (TREE_TYPE (@0)))
    (cmp @1 @0))))
 
+/* Optimize A - B + -1 >= A into B >= A for unsigned comparisons.  */
+(for cmp (ge lt)
+ (simplify
+  (cmp:c (plus (minus @0 @1) integer_minus_onep) @0)
+   (if (ANY_INTEGRAL_TYPE_P (TREE_TYPE (@0))
+       && TYPE_UNSIGNED (TREE_TYPE (@0)))
+    (cmp @1 @0))))
+
 /* Testing for overflow is unnecessary if we already know the result.  */
 /* A - B > A  */
 (for cmp (gt le)

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 088b80ea38f1009b46e446a1370b0f271a781e80..43e226e7e1889dd8ef25269f4d294afa7982e4ac 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2020-05-08  Jakub Jelinek  <jakub@redhat.com>
+
+       PR tree-optimization/94913
+       * gcc.dg/tree-ssa/pr94913.c: New test.
+
 2020-05-07  Segher Boessenkool  <segher@kernel.crashing.org>
 
        * gcc.target/powerpc/setnbc.h: New.

diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pr94913.c b/gcc/testsuite/gcc.dg/tree-ssa/pr94913.c
new file mode 100644 (file)
index 0000000..6b71f98
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/tree-ssa/pr94913.c
@@ -0,0 +1,33 @@
+/* PR tree-optimization/94913 */
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-tree-optimized" } */
+/* { dg-final { scan-tree-dump " (?:b_\[0-9]+\\\(D\\\) >= a|a_\[0-9]+\\\(D\\\) <= b)_\[0-9]+\\\(D\\\);" "optimized" } } */
+/* { dg-final { scan-tree-dump " (?:c_\[0-9]+\\\(D\\\) > d|d_\[0-9]+\\\(D\\\) < c)_\[0-9]+\\\(D\\\);" "optimized" } } */
+/* { dg-final { scan-tree-dump " (?:f_\[0-9]+\\\(D\\\) >= e|e_\[0-9]+\\\(D\\\) <= f)_\[0-9]+\\\(D\\\);" "optimized" } } */
+/* { dg-final { scan-tree-dump " (?:g_\[0-9]+\\\(D\\\) > h|h_\[0-9]+\\\(D\\\) < g)_\[0-9]+\\\(D\\\);" "optimized" } } */
+
+int
+foo (unsigned a, unsigned b)
+{
+  return (a - b - 1) >= a;
+}
+
+int
+bar (unsigned c, unsigned d)
+{
+  return (c - d - 1) < c;
+}
+
+int
+baz (unsigned e, unsigned f)
+{
+  unsigned t = e - f;
+  return (t - 1) >= e;
+}
+
+int
+qux (unsigned g, unsigned h)
+{
+  unsigned t = g - h;
+  return (t - 1) < g;
+}