From: Robert Jordens <jordens@gmail.com>
Date: Wed, 19 Mar 2014 23:47:26 +0000 (-0600)
Subject: genlib/coding: gracefully handle flen(i) < 2
X-Git-Tag: 24jan2021_ls180~2099^2~375
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=0023b742e4c4c48642247a4cb55962f9141dfb98;p=litex.git

genlib/coding: gracefully handle flen(i) < 2
---

diff --git a/migen/genlib/coding.py b/migen/genlib/coding.py
index ed031557..df89f6cc 100644
--- a/migen/genlib/coding.py
+++ b/migen/genlib/coding.py
@@ -26,7 +26,7 @@ class Encoder(Module):
 	"""
 	def __init__(self, width):
 		self.i = Signal(width) # one-hot
-		self.o = Signal(max=width) # binary
+		self.o = Signal(max=max(2, width)) # binary
 		self.n = Signal() # invalid: none or multiple
 		act = dict((1<<j, self.o.eq(j)) for j in range(width))
 		act["default"] = self.n.eq(1)
@@ -54,7 +54,7 @@ class PriorityEncoder(Module):
 	"""
 	def __init__(self, width):
 		self.i = Signal(width) # one-hot, lsb has priority
-		self.o = Signal(max=width) # binary
+		self.o = Signal(max=max(2, width)) # binary
 		self.n = Signal() # none
 		for j in range(width)[::-1]: # last has priority
 			self.comb += If(self.i[j], self.o.eq(j))
@@ -82,7 +82,7 @@ class Decoder(Module):
 	"""
 
 	def __init__(self, width):
-		self.i = Signal(max=width) # binary
+		self.i = Signal(max=max(2, width)) # binary
 		self.n = Signal() # none/invalid
 		self.o = Signal(width) # one-hot
 		act = dict((j, self.o.eq(1<<j)) for j in range(width))
diff --git a/migen/test/test_coding.py b/migen/test/test_coding.py
index 1a61158a..c21d726f 100644
--- a/migen/test/test_coding.py
+++ b/migen/test/test_coding.py
@@ -75,3 +75,28 @@ class DecCase(SimCase, unittest.TestCase):
 			else:
 				self.assertEqual(o, 1<<i)
 		self.run_with(cb, 256)
+
+class SmallPrioEncCase(SimCase, unittest.TestCase):
+	class TestBench(SimBench):
+		def __init__(self):
+			self.submodules.dut = PriorityEncoder(1)
+
+	def test_sizes(self):
+		self.assertEqual(flen(self.tb.dut.i), 1)
+		self.assertEqual(flen(self.tb.dut.o), 1)
+		self.assertEqual(flen(self.tb.dut.n), 1)
+
+	def test_run_sequence(self):
+		seq = list(range(1))
+		def cb(tb, tbp):
+			if seq:
+				tbp.dut.i = seq.pop(0)
+			i = tbp.dut.i
+			if tbp.dut.n:
+				self.assertEqual(i, 0)
+			else:
+				o = tbp.dut.o
+				if o > 0:
+					self.assertEqual(i & 1<<(o - 1), 0)
+				self.assertGreaterEqual(i, 1<<o)
+		self.run_with(cb, 5)