From: Kenneth Graunke <kenneth@whitecape.org>
Date: Tue, 20 Jul 2010 06:45:23 +0000 (-0700)
Subject: glsl2: Add some comments.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=0048c7aef82b17c6bd160f49125a91a70cbf2b55;p=mesa.git

glsl2: Add some comments.
---

diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp
index 2348bdf24fa..1122521e0dc 100644
--- a/src/glsl/ast_function.cpp
+++ b/src/glsl/ast_function.cpp
@@ -164,6 +164,9 @@ match_function_by_name(exec_list *instructions, const char *name,
 
 /**
  * Perform automatic type conversion of constructor parameters
+ *
+ * This implements the rules in the "Conversion and Scalar Constructors"
+ * section (GLSL 1.10 section 5.4.1), not the "Implicit Conversions" rules.
  */
 static ir_rvalue *
 convert_component(ir_rvalue *src, const glsl_type *desired_type)
@@ -220,11 +223,11 @@ convert_component(ir_rvalue *src, const glsl_type *desired_type)
 
    assert(result != NULL);
 
+   /* Try constant folding; it may fold in the conversion we just added. */
    ir_constant *const constant = result->constant_expression_value();
    return (constant != NULL) ? (ir_rvalue *) constant : (ir_rvalue *) result;
 }
 
-
 /**
  * Dereference a specific component from a scalar, vector, or matrix
  */