From: Luis Machado <lgustavo@codesourcery.com>
Date: Mon, 24 Oct 2016 22:44:56 +0000 (-0500)
Subject: Fix obvious gotcha in string comparison
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=010ece9c47f1ac08c9436b133a74472713dd709b;p=binutils-gdb.git

Fix obvious gotcha in string comparison

This patch fixes a gotcha when comparing exception's messages in
exception_print_same. It should've used the statically-allocated
string versions msg1 and msg2 instead.

As is, it could lead to crashes.

gdb/ChangeLog:
2016-10-24  Luis Machado  <lgustavo@codesourcery.com>

	* exec.c (exception_print_same): Fix string comparison to use
	statically-allocated ones.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index be72369adb8..388cc1ff61f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2016-10-24  Luis Machado  <lgustavo@codesourcery.com>
+
+	* exec.c (exception_print_same): Fix string comparison to use
+	statically-allocated ones.
+
 2016-10-21  Tom Tromey  <tom@tromey.com>
 
 	* dwarf2expr.h (class dwarf_expr_context)
diff --git a/gdb/exec.c b/gdb/exec.c
index d858e996a8d..67ecc636307 100644
--- a/gdb/exec.c
+++ b/gdb/exec.c
@@ -152,7 +152,7 @@ exception_print_same (struct gdb_exception e1, struct gdb_exception e2)
 
   return (e1.reason == e2.reason
 	  && e1.error == e2.error
-	  && strcmp (e1.message, e2.message) == 0);
+	  && strcmp (msg1, msg2) == 0);
 }
 
 /* See gdbcore.h.  */