From: Alan Modra <amodra@gmail.com>
Date: Wed, 2 Sep 2020 00:56:31 +0000 (+0930)
Subject: ubsan: tc-z80.c:3656 shift exponent 32 is too large
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=01a6f9da644e52fbd644a8e8f58d58c0383118c8;p=binutils-gdb.git

ubsan: tc-z80.c:3656 shift exponent 32 is too large

	* config/tc-z80.c (is_overflow): Avoid too large shift.
---

diff --git a/gas/ChangeLog b/gas/ChangeLog
index d6b58b48527..641b68de66a 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,7 @@
+2020-09-02  Alan Modra  <amodra@gmail.com>
+
+	* config/tc-z80.c (is_overflow): Avoid too large shift.
+
 2020-09-02  Alan Modra  <amodra@gmail.com>
 
 	* config/tc-sparc.c (in_signed_range): Use an unsigned type for
diff --git a/gas/config/tc-z80.c b/gas/config/tc-z80.c
index 45fcd6fbf74..2e17d005522 100644
--- a/gas/config/tc-z80.c
+++ b/gas/config/tc-z80.c
@@ -3653,7 +3653,7 @@ md_assemble (char *str)
 static int
 is_overflow (long value, unsigned bitsize)
 {
-  long fieldmask = (1UL << bitsize) - 1;
+  long fieldmask = (2UL << (bitsize - 1)) - 1;
   long signmask = ~fieldmask;
   long a = value & fieldmask;
   long ss = a & signmask;