From: Francisco Jerez Date: Mon, 8 Aug 2016 19:44:12 +0000 (-0700) Subject: i965/fs: Drop bogus writemasking disable bit from HALT instructions. X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=01b321f2420d45e9353c94bcf5d96cae6c2deac2;p=mesa.git i965/fs: Drop bogus writemasking disable bit from HALT instructions. This may have been the reason people ran into problems with non-uniform HALT instructions and ended up using the inefficient ANY16H/ANY8H predicates instead of ANY4H or NORMAL in order to prevent non-uniform discard. The HALT instruction is able to handle non-uniform execution masks just fine. Reviewed-by: Jason Ekstrand --- diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp index 647950f8d7c..22190f804f1 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp +++ b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp @@ -1053,11 +1053,7 @@ fs_generator::generate_discard_jump(fs_inst *inst) * current block (or the program). */ this->discard_halt_patches.push_tail(new(mem_ctx) ip_record(p->nr_insn)); - - brw_push_insn_state(p); - brw_set_default_mask_control(p, BRW_MASK_DISABLE); gen6_HALT(p); - brw_pop_insn_state(p); } void