From: Ian Romanick <ian.d.romanick@intel.com>
Date: Tue, 1 Sep 2009 18:58:36 +0000 (-0700)
Subject: Don't dereference function pointers in calls.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=0342dce226fe79d7a6c0e7cd735c596fad3e8aac;p=mesa.git

Don't dereference function pointers in calls.

I'm apparently alone in prefering this calling convention, so I'll be
a team player. :p  Based on review comments by Brian Paul and Eric
Anholt.
---

diff --git a/src/mesa/main/syncobj.c b/src/mesa/main/syncobj.c
index b3c75c747a7..075931c7cef 100644
--- a/src/mesa/main/syncobj.c
+++ b/src/mesa/main/syncobj.c
@@ -183,7 +183,7 @@ _mesa_unref_sync_object(GLcontext *ctx, struct gl_sync_object *syncObj)
       remove_from_list(& syncObj->link);
       _glthread_UNLOCK_MUTEX(ctx->Shared->Mutex);
 
-      (*ctx->Driver.DeleteSyncObject)(ctx, syncObj);
+      ctx->Driver.DeleteSyncObject(ctx, syncObj);
    } else {
       _glthread_UNLOCK_MUTEX(ctx->Shared->Mutex);
    }
@@ -250,7 +250,7 @@ _mesa_FenceSync(GLenum condition, GLbitfield flags)
       return 0;
    }
 
-   syncObj = (*ctx->Driver.NewSyncObject)(ctx, GL_SYNC_FENCE);
+   syncObj = ctx->Driver.NewSyncObject(ctx, GL_SYNC_FENCE);
    if (syncObj != NULL) {
       syncObj->Type = GL_SYNC_FENCE;
       /* The name is not currently used, and it is never visible to
@@ -265,7 +265,7 @@ _mesa_FenceSync(GLenum condition, GLbitfield flags)
       syncObj->Flags = flags;
       syncObj->Status = 0;
 
-      (*ctx->Driver.FenceSync)(ctx, syncObj, condition, flags);
+      ctx->Driver.FenceSync(ctx, syncObj, condition, flags);
 
       _glthread_LOCK_MUTEX(ctx->Shared->Mutex);
       insert_at_tail(& ctx->Shared->SyncObjects, & syncObj->link);
@@ -305,11 +305,11 @@ _mesa_ClientWaitSync(GLsync sync, GLbitfield flags, GLuint64 timeout)
     *    ClientWaitSync was called. ALREADY_SIGNALED will always be returned
     *    if <sync> was signaled, even if the value of <timeout> is zero.
     */
-   (*ctx->Driver.CheckSync)(ctx, syncObj);
+   ctx->Driver.CheckSync(ctx, syncObj);
    if (syncObj->Status) {
       ret = GL_ALREADY_SIGNALED;
    } else {
-      (*ctx->Driver.ClientWaitSync)(ctx, syncObj, flags, timeout);
+      ctx->Driver.ClientWaitSync(ctx, syncObj, flags, timeout);
 
       ret = syncObj->Status ? GL_CONDITION_SATISFIED : GL_TIMEOUT_EXPIRED;
    }
@@ -344,7 +344,7 @@ _mesa_WaitSync(GLsync sync, GLbitfield flags, GLuint64 timeout)
       return;
    }
 
-   (*ctx->Driver.ServerWaitSync)(ctx, syncObj, flags, timeout);
+   ctx->Driver.ServerWaitSync(ctx, syncObj, flags, timeout);
 }
 
 
@@ -379,7 +379,7 @@ _mesa_GetSynciv(GLsync sync, GLenum pname, GLsizei bufSize, GLsizei *length,
        * this call won't block.  It just updates state in the common object
        * data from the current driver state.
        */
-      (*ctx->Driver.CheckSync)(ctx, syncObj);
+      ctx->Driver.CheckSync(ctx, syncObj);
 
       v[0] = (syncObj->Status) ? GL_SIGNALED : GL_UNSIGNALED;
       size = 1;