From: Iago Toral Quiroga <itoral@igalia.com>
Date: Mon, 7 Aug 2017 04:18:24 +0000 (+0200)
Subject: TextureStorage1D should return INVALID_OPERATION if target is not a 1D texture
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=0415ef9ccd06388c8f60726032f0814b66850312;p=mesa.git

TextureStorage1D should return INVALID_OPERATION if target is not a 1D texture

Previous behavior was inconsistent with other texture targets so this has been
fixed in OpenGL 4.6.

Fixes:
KHR-GL45.direct_state_access.textures_storage_errors

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
---

diff --git a/src/mesa/main/texstorage.c b/src/mesa/main/texstorage.c
index e0930abe3f8..44edba33235 100644
--- a/src/mesa/main/texstorage.c
+++ b/src/mesa/main/texstorage.c
@@ -605,7 +605,7 @@ texturestorage_error(GLuint dims, GLuint texture, GLsizei levels,
     * can receive unsized formats.
     */
    if (!legal_texobj_target(ctx, dims, texObj->Target)) {
-      _mesa_error(ctx, GL_INVALID_ENUM,
+      _mesa_error(ctx, GL_INVALID_OPERATION,
                   "%s(illegal target=%s)", caller,
                   _mesa_enum_to_string(texObj->Target));
       return;