From: Brian Paul Date: Thu, 22 Jun 2017 18:58:39 +0000 (-0600) Subject: svga: check return value from svga_set_shader( SVGA3D_SHADERTYPE_GS, NULL) X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=041f8ae9f6bab39361263f6c767ea5294f1aa011;p=mesa.git svga: check return value from svga_set_shader( SVGA3D_SHADERTYPE_GS, NULL) If the call fails we need to flush the command buffer and retry. In this case, we were failing to unbind the GS which led to subsequent errors. This fixes a bug replaying a Cinebench R15 apitrace in a Linux guest. VMware bug 1894451 cc: mesa-stable@lists.freedesktop.org Reviewed-by: Charmaine Lee --- diff --git a/src/gallium/drivers/svga/svga_state_gs.c b/src/gallium/drivers/svga/svga_state_gs.c index cff11ad5c3f..217463882f1 100644 --- a/src/gallium/drivers/svga/svga_state_gs.c +++ b/src/gallium/drivers/svga/svga_state_gs.c @@ -190,6 +190,8 @@ emit_hw_gs(struct svga_context *svga, unsigned dirty) * Needs to unbind the geometry shader. */ ret = svga_set_shader(svga, SVGA3D_SHADERTYPE_GS, NULL); + if (ret != PIPE_OK) + goto done; svga->state.hw_draw.gs = NULL; } goto done;