From: Brian Paul Date: Mon, 2 May 2016 16:29:52 +0000 (-0600) Subject: svga: try to flag surfaces for sampling, in addition to rendering X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=05abaa65c745d74fb296006285b85d253cb11525;p=mesa.git svga: try to flag surfaces for sampling, in addition to rendering This silences some warnings when we try to sample from surfaces that were created for drawing, such as when blitting from one of the framebuffer surfaces. We were already doing the opposite situation (adding a bind flag for rendering to surfaces declared as texture sources). Reviewed-by: Charmaine Lee --- diff --git a/src/gallium/drivers/svga/svga_resource_texture.c b/src/gallium/drivers/svga/svga_resource_texture.c index f176647dcf6..b7e8549b782 100644 --- a/src/gallium/drivers/svga/svga_resource_texture.c +++ b/src/gallium/drivers/svga/svga_resource_texture.c @@ -839,6 +839,17 @@ svga_texture_create(struct pipe_screen *screen, tex->key.cachable = 1; + if ((bindings & (PIPE_BIND_RENDER_TARGET | PIPE_BIND_DEPTH_STENCIL)) && + !(bindings & PIPE_BIND_SAMPLER_VIEW)) { + /* Also check if the format can be sampled from */ + if (screen->is_format_supported(screen, template->format, + template->target, + template->nr_samples, + PIPE_BIND_SAMPLER_VIEW)) { + bindings |= PIPE_BIND_SAMPLER_VIEW; + } + } + if (bindings & PIPE_BIND_SAMPLER_VIEW) { tex->key.flags |= SVGA3D_SURFACE_HINT_TEXTURE; tex->key.flags |= SVGA3D_SURFACE_BIND_SHADER_RESOURCE;