From: Jakub Jelinek <jakub@redhat.com>
Date: Sat, 30 May 2020 12:02:56 +0000 (+0200)
Subject: openmp: omp_alloc(0, ...) should return NULL.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=05e4db63d044ee235d2fbfab8b0bb9fbdfb18315;p=gcc.git

openmp: omp_alloc(0, ...) should return NULL.

2020-05-30  Jakub Jelinek  <jakub@redhat.com>

	* allocator.c (omp_alloc): For size == 0, return NULL early.

	* testsuite/libgomp.c-c++-common/alloc-4.c: New test.
---

diff --git a/libgomp/allocator.c b/libgomp/allocator.c
index 8592de6e2b5..66308ab6669 100644
--- a/libgomp/allocator.c
+++ b/libgomp/allocator.c
@@ -201,6 +201,9 @@ omp_alloc (size_t size, omp_allocator_handle_t allocator)
   size_t alignment, new_size;
   void *ptr, *ret;
 
+  if (__builtin_expect (size == 0, 0))
+    return NULL;
+
 retry:
   if (allocator == omp_null_allocator)
     {
diff --git a/libgomp/testsuite/libgomp.c-c++-common/alloc-4.c b/libgomp/testsuite/libgomp.c-c++-common/alloc-4.c
new file mode 100644
index 00000000000..841e1bcc201
--- /dev/null
+++ b/libgomp/testsuite/libgomp.c-c++-common/alloc-4.c
@@ -0,0 +1,25 @@
+#include <omp.h>
+#include <stdlib.h>
+
+const omp_alloctrait_t traits[]
+= { { omp_atk_pool_size, 1 },
+    { omp_atk_fallback, omp_atv_abort_fb } };
+
+int
+main ()
+{
+  omp_allocator_handle_t a;
+
+  if (omp_alloc (0, omp_null_allocator) != NULL)
+    abort ();
+  a = omp_init_allocator (omp_default_mem_space, 2, traits);
+  if (a != omp_null_allocator)
+    {
+      if (omp_alloc (0, a) != NULL
+	  || omp_alloc (0, a) != NULL
+	  || omp_alloc (0, a) != NULL)
+	abort ();
+      omp_destroy_allocator (a);
+    }
+  return 0;
+}