From: Yann Rouillard <yann@pleiades.fr.eu.org>
Date: Thu, 23 May 2013 22:40:56 +0000 (+0200)
Subject: add some comments in the solaris unit test
X-Git-Tag: v0.22~58
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=0606b4bb10a10b51def8fb8f3c931531f1d4a07a;p=pyelftools.git

add some comments in the solaris unit test
---

diff --git a/test/test_solaris_support.py b/test/test_solaris_support.py
index 2f48825..0b7834c 100644
--- a/test/test_solaris_support.py
+++ b/test/test_solaris_support.py
@@ -24,11 +24,17 @@ class TestSolarisSupport(unittest.TestCase):
             syminfo_section = elf.get_section_by_name('.SUNW_syminfo')
             self.assertIsNotNone(syminfo_section)
 
+            # The test files were compiled against libc.so.1 with
+            # direct binding, hence the libc symbols used 
+            # (exit, atexit and _exit) have the direct binding flags
+            # in the syminfo table.
+            # We check that this is properly detected.
             exit_symbols = [s for s in syminfo_section.iter_symbols()
                             if 'exit' in s.name]
             self.assertNotEqual(len(exit_symbols), 0)
 
             for symbol in exit_symbols:
+                # libc.so.1 has the index 0 in the dynamic table
                 self.assertEqual(symbol['si_boundto'], 0)
                 self.assertEqual(symbol['si_flags'],
                                  SYMINFO_FLAGS.SYMINFO_FLG_DIRECT |