From: Tom Tromey <tom@tromey.com>
Date: Thu, 8 Apr 2021 21:15:59 +0000 (-0600)
Subject: Avoid sequence point warning in h8300 sim
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=06a88b3b3948db72b662345ac7abf90bd1c14a44;p=binutils-gdb.git

Avoid sequence point warning in h8300 sim

GCC gives a -Wsequence-point warning for this code in the h8300 sim.
The bug is that memory_size is both assigned and used in the same
expression.  The fix is to assign after the print.

sim/h8300/ChangeLog
2021-04-08  Tom Tromey  <tom@tromey.com>

	* compile.c (init_pointers): Fix sequence point warning.
---

diff --git a/sim/h8300/ChangeLog b/sim/h8300/ChangeLog
index cd47d25f02d..2b2c6a73fc0 100644
--- a/sim/h8300/ChangeLog
+++ b/sim/h8300/ChangeLog
@@ -1,3 +1,7 @@
+2021-04-08  Tom Tromey  <tom@tromey.com>
+
+	* compile.c (init_pointers): Fix sequence point warning.
+
 2021-04-08  Tom Tromey  <tom@tromey.com>
 
 	* compile.c (cmdline_location): Use new-style declaration.
diff --git a/sim/h8300/compile.c b/sim/h8300/compile.c
index c30a738c6d1..c8060b27ab7 100644
--- a/sim/h8300/compile.c
+++ b/sim/h8300/compile.c
@@ -1624,7 +1624,8 @@ init_pointers (SIM_DESC sd)
 	  sim_io_printf
 	    (sd,
 	     "init_pointers: bad memory size %d, defaulting to %d.\n", 
-	     memory_size, memory_size = H8300S_MSIZE);
+	     memory_size, H8300S_MSIZE);
+	  memory_size = H8300S_MSIZE;
 	}
 
       if (h8_get_memory_buf (sd))