From: Simon Marchi Date: Sun, 25 Jun 2017 10:49:19 +0000 (+0200) Subject: dtrace-probe: Put semicolon after while on its own line X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=07809eafc959a0c588663c0c949eaf8044a1b40a;p=binutils-gdb.git dtrace-probe: Put semicolon after while on its own line clang shows this warning. /home/emaisin/src/binutils-gdb/gdb/dtrace-probe.c:424:52: error: while loop has empty body [-Werror,-Wempty-body] while (*p++ != '\0' && p - strtab < strtab_size); ^ /home/emaisin/src/binutils-gdb/gdb/dtrace-probe.c:424:52: note: put the semicolon on a separate line to silence this warning Putting the semicolon on its own line is not a big sacrifice to get rid of this warning. I think it's also useful to keep this, because it can catch errors like this: while (something); { ... } although gcc would warn about it in a different way (misleading indentation). This warning is already discussed here in the GCC bugzilla: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62184 gdb/ChangeLog: * dtrace-probe.c (dtrace_process_dof_probe): Put semi-colon on its own line. --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 7914b1dd3c9..7c48bf4ba77 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2017-06-25 Simon Marchi + + * dtrace-probe.c (dtrace_process_dof_probe): Put semi-colon on + its own line. + 2017-06-25 Simon Marchi * nat/x86-dregs.c (x86_show_dr): Print registers one per line. diff --git a/gdb/dtrace-probe.c b/gdb/dtrace-probe.c index 122f8ded91b..c611b16375d 100644 --- a/gdb/dtrace-probe.c +++ b/gdb/dtrace-probe.c @@ -421,7 +421,8 @@ dtrace_process_dof_probe (struct objfile *objfile, arg.type_str = xstrdup (p); /* Use strtab_size as a sentinel. */ - while (*p++ != '\0' && p - strtab < strtab_size); + while (*p++ != '\0' && p - strtab < strtab_size) + ; /* Try to parse a type expression from the type string. If this does not work then we set the type to `long