From: Tom Tromey <tom@tromey.com>
Date: Wed, 5 Sep 2018 06:00:31 +0000 (-0600)
Subject: Remove unnecessary casts from cli-cmds.c
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=081bca4d622143b229cf02a1dda4afb9b457eefa;p=binutils-gdb.git

Remove unnecessary casts from cli-cmds.c

I noticed a couple of unnecessary casts in cli-cmds.c.  This patch
removes them.

Tested by rebuilding.  I'm checking this in.

gdb/ChangeLog
2018-09-05  Tom Tromey  <tom@tromey.com>

	* cli/cli-cmds.c (shell_escape, edit_command): Remove cast.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 0f8599bb166..084765d29c1 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2018-09-05  Tom Tromey  <tom@tromey.com>
+
+	* cli/cli-cmds.c (shell_escape, edit_command): Remove cast.
+
 2018-09-05  Tom de Vries  <tdevries@suse.de>
 
 	* dwarf2loc.c (sect_variable_value): Call indirect_synthetic_pointer
diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c
index 4694553b7dd..c60e5efd0cc 100644
--- a/gdb/cli/cli-cmds.c
+++ b/gdb/cli/cli-cmds.c
@@ -730,7 +730,7 @@ shell_escape (const char *arg, int from_tty)
 
       close_most_fds ();
 
-      if ((user_shell = (char *) getenv ("SHELL")) == NULL)
+      if ((user_shell = getenv ("SHELL")) == NULL)
 	user_shell = "/bin/sh";
 
       /* Get the name of the shell for arg0.  */
@@ -850,8 +850,8 @@ edit_command (const char *arg, int from_tty)
         error (_("No line number known for %s."), arg);
     }
 
-  if ((editor = (char *) getenv ("EDITOR")) == NULL)
-      editor = "/bin/ex";
+  if ((editor = getenv ("EDITOR")) == NULL)
+    editor = "/bin/ex";
 
   fn = symtab_to_fullname (sal.symtab);