From: Simon Marchi <simon.marchi@efficios.com>
Date: Wed, 13 Apr 2022 15:15:38 +0000 (-0400)
Subject: gdb: add ATTRIBUTE_PRINTF to complaint_interceptor::issue_complaint
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=08755c5aadfff98c4c3db60f3043589015414f11;p=binutils-gdb.git

gdb: add ATTRIBUTE_PRINTF to complaint_interceptor::issue_complaint

Fix this error when building with clang++-14:

      CXX    complaints.o
    /home/smarchi/src/binutils-gdb/gdb/complaints.c:130:65: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
      g_complaint_interceptor->m_complaints.insert (string_vprintf (fmt, args));
                                                                    ^~~

Change-Id: I0ef11f970510eb8638d1651fa0d5eeecd6a9d31a
---

diff --git a/gdb/complaints.h b/gdb/complaints.h
index 09d8cd39b27..68c79bd6d0a 100644
--- a/gdb/complaints.h
+++ b/gdb/complaints.h
@@ -70,11 +70,12 @@ private:
 
   /* The saved value of deprecated_warning_hook.  */
   void (*m_saved_warning_hook) (const char *, va_list)
-    ATTRIBUTE_FPTR_PRINTF(1,0);
+    ATTRIBUTE_FPTR_PRINTF (1,0);
 
   /* A helper function that is used by the 'complaint' implementation
      to issue a complaint.  */
-  static void issue_complaint (const char *, va_list);
+  static void issue_complaint (const char *, va_list)
+    ATTRIBUTE_PRINTF (1, 0);
 
   /* This object.  Used by the static callback function.  */
   static complaint_interceptor *g_complaint_interceptor;