From: Andrew Cagney <cagney@redhat.com>
Date: Thu, 1 Mar 2001 18:19:28 +0000 (+0000)
Subject: * Makefile.in (os9kread.o): Do not compile with WERROR_CFLAGS.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=088d891f588eb06a92f4fccf6a76e9b6ef2014c2;p=binutils-gdb.git

* Makefile.in (os9kread.o): Do not compile with WERROR_CFLAGS.
* os9kread.c (os9k_process_one_symbol): Add assert to detect
``loses if sizeof (char *) > sizeof (int)''.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d3d62bef7dc..7714fd67d8a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2001-03-01  Andrew Cagney  <ac131313@redhat.com>
+
+	* Makefile.in (os9kread.o): Do not compile with WERROR_CFLAGS.
+	* os9kread.c (os9k_process_one_symbol): Add assert to detect
+	``loses if sizeof (char *) > sizeof (int)''.
+
 2001-03-01  Andrew Cagney  <ac131313@redhat.com>
 
 	* gdb_assert.h: Document pragmatics behind gdb_assert's case.
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 01165a052e7..c619fc58ab5 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -1635,10 +1635,13 @@ mdebugread.o: mdebugread.c buildsym.h complaints.h $(bfd_h) $(defs_h) \
 
 mipsm3-nat.o: mipsm3-nat.c $(defs_h) $(inferior_h) $(regcache_h)
 
+# os9kread assumes that sizeof(char*) <= sizeof(int).  This looses on
+# 64 bit targets where often, sizeof(int)=4 but sizeof(char*)=9.
 os9kread.o: os9kread.c buildsym.h complaints.h $(bfd_h) $(defs_h) \
-        $(expression_h) gdb-stabs.h $(gdbcore_h) $(gdbtypes_h) language.h \
-        objfiles.h stabsread.h symfile.h $(symtab_h) \
-	target.h gdb_string.h
+	        $(expression_h) gdb-stabs.h $(gdbcore_h) $(gdbtypes_h) \
+		language.h objfiles.h stabsread.h symfile.h $(symtab_h) \
+		target.h gdb_string.h
+	$(CC) -c $(INTERNAL_WARN_CFLAGS) $(NO_WERROR_CFLAGS) $<
 
 mem-break.o: mem-break.c $(defs_h) 
 
diff --git a/gdb/os9kread.c b/gdb/os9kread.c
index 00a59968bcd..a3d67fcc10b 100644
--- a/gdb/os9kread.c
+++ b/gdb/os9kread.c
@@ -35,6 +35,7 @@
 
 #include "defs.h"
 #include "gdb_string.h"
+#include "gdb_assert.h"
 #include <stdio.h>
 
 #if defined(USG) || defined(__CYGNUSCLIB__)
@@ -1509,6 +1510,7 @@ os9k_process_one_symbol (int type, int desc, CORE_ADDR valu, char *name,
       /* Relocate for dynamic loading and for ELF acc fn-relative syms.  */
       valu += ANOFFSET (section_offsets, SECT_OFF_TEXT (objfile));
       /* FIXME: loses if sizeof (char *) > sizeof (int) */
+      gdb_assert (sizeof (name) <= sizeof (int));
       record_line (current_subfile, (int) name, valu);
       break;