From: Bas Nieuwenhuizen Date: Thu, 16 Jan 2020 01:33:35 +0000 (+0100) Subject: radv: Allow DCC & TC-compat HTILE with VK_IMAGE_CREATE_EXTENDED_USAGE_BIT. X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=0890482969d1331b0cf876ca1ab6f06486817bef;p=mesa.git radv: Allow DCC & TC-compat HTILE with VK_IMAGE_CREATE_EXTENDED_USAGE_BIT. I misunderstood the flag when initially disabling. But this flag only does something with mutable formats. If we have DCC and mutable formats, the formats are close enough that the allowed usage flags are not meaningfully different nor used during allocation. Reviewed-by: Samuel Pitoiset Tested-by: Marge Bot Part-of: --- diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c index 1640d9c5019..89925386796 100644 --- a/src/amd/vulkan/radv_image.c +++ b/src/amd/vulkan/radv_image.c @@ -72,8 +72,7 @@ radv_use_tc_compat_htile_for_image(struct radv_device *device, if (device->physical_device->rad_info.chip_class < GFX8) return false; - if ((pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT) || - (pCreateInfo->flags & VK_IMAGE_CREATE_EXTENDED_USAGE_BIT)) + if ((pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT)) return false; if (pCreateInfo->tiling == VK_IMAGE_TILING_LINEAR) @@ -159,8 +158,7 @@ radv_use_dcc_for_image(struct radv_device *device, return false; /* TODO: Enable DCC for storage images. */ - if ((pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT) || - (pCreateInfo->flags & VK_IMAGE_CREATE_EXTENDED_USAGE_BIT)) + if ((pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT)) return false; if (pCreateInfo->tiling == VK_IMAGE_TILING_LINEAR)