From: Tom Tromey <tom@tromey.com>
Date: Thu, 3 May 2018 22:36:16 +0000 (-0600)
Subject: Remove dead code in end_psymtab
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=08994e1ddcc8e5e1e003602409662ae799a1ff30;p=binutils-gdb.git

Remove dead code in end_psymtab

I noticed that there is a bit of dead code in end_psymtab.
This deletes it.

Normally I would investigate a fix for the code.  However, considering
that the code has been this way a long time (since the first import to
sourceware) and considering that dbxread.c is not as important any
more, I think it's safe to just consider that there's no bug.

gdb/ChangeLog
2018-07-26  Tom Tromey  <tromey@redhat.com>

	* dbxread.c (end_psymtab): Remove dead code.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 26c1fd4cb81..4c2058dab90 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2018-07-26  Tom Tromey  <tromey@redhat.com>
+
+	* dbxread.c (end_psymtab): Remove dead code.
+
 2018-07-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 
 	* dwarf2-frame-tailcall.c (tailcall_frame_sniffer): Exit early if
diff --git a/gdb/dbxread.c b/gdb/dbxread.c
index d8864f33f9a..fe9e842ba1a 100644
--- a/gdb/dbxread.c
+++ b/gdb/dbxread.c
@@ -2051,13 +2051,7 @@ dbx_end_psymtab (struct objfile *objfile, struct partial_symtab *pst,
       ALL_OBJFILE_PSYMTABS (objfile, p1)
       {
 	if (p1->texthigh == 0 && p1->textlow != 0 && p1 != pst)
-	  {
-	    p1->texthigh = pst->textlow;
-	    /* If this file has only data, then make textlow match
-	       texthigh.  */
-	    if (p1->textlow == 0)
-	      p1->textlow = p1->texthigh;
-	  }
+	  p1->texthigh = pst->textlow;
       }
     }