From: Eric Anholt <eric@anholt.net>
Date: Wed, 25 Apr 2018 23:16:27 +0000 (-0700)
Subject: broadcom/vc5: Add validation that we don't violate GFXH-1625 requirements.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=089c32eefd2f9afcbfc87349beacbdf9d005cfac;p=mesa.git

broadcom/vc5: Add validation that we don't violate GFXH-1625 requirements.

We don't use TMUWT yet, but we will once we do SSBOs.
---

diff --git a/src/broadcom/compiler/qpu_validate.c b/src/broadcom/compiler/qpu_validate.c
index 492f2e64d09..b459d81b446 100644
--- a/src/broadcom/compiler/qpu_validate.c
+++ b/src/broadcom/compiler/qpu_validate.c
@@ -247,6 +247,11 @@ qpu_validate_inst(struct v3d_qpu_validate_state *state, struct qinst *qinst)
 
                 if (v3d_qpu_sig_writes_address(devinfo, &inst->sig))
                         fail_instr(state, "RF write after THREND");
+
+                /* GFXH-1625: No TMUWT in the last instruction */
+                if (state->last_thrsw_ip - state->ip == 2 &&
+                    inst->alu.add.op == V3D_QPU_A_TMUWT)
+                        fail_instr(state, "TMUWT in last instruction");
         }
 
         if (inst->type == V3D_QPU_INSTR_TYPE_BRANCH) {