From: Eric Anholt <eric@anholt.net>
Date: Fri, 26 Jun 2020 23:31:55 +0000 (-0700)
Subject: v3d: Fix -Wmaybe-uninitialized compiler warning in the v33 code.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=08c39a8a2931e587e4715d2ed12b2fe1990aa4c3;p=mesa.git

v3d: Fix -Wmaybe-uninitialized compiler warning in the v33 code.

We weren't initializing the VCM bits in the !gs path, but v33 doesn't have
GS so we can just mark it unreachable.

Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/2952>
---

diff --git a/src/gallium/drivers/v3d/v3dx_draw.c b/src/gallium/drivers/v3d/v3dx_draw.c
index f4377e79d4a..9a5da07ec80 100644
--- a/src/gallium/drivers/v3d/v3dx_draw.c
+++ b/src/gallium/drivers/v3d/v3dx_draw.c
@@ -706,8 +706,8 @@ v3d_emit_gl_shader_state(struct v3d_context *v3d,
                 vpm_cfg.Ve = 0;
                 vpm_cfg.Vc = v3d->prog.vs->prog_data.vs->vcm_cache_size;
         }
-#if V3D_VERSION >= 41
         else {
+#if V3D_VERSION >= 41
                 v3d_emit_gs_state_record(v3d->job,
                                          v3d->prog.gs_bin, gs_bin_uniforms,
                                          v3d->prog.gs, gs_uniforms);
@@ -738,8 +738,10 @@ v3d_emit_gl_shader_state(struct v3d_context *v3d,
                                               vpm_cfg.gs_width,
                                               vpm_cfg.Gd,
                                               vpm_cfg.Gv);
-        }
+#else
+                unreachable("No GS support pre-4.1");
 #endif
+        }
 
         cl_emit(&job->indirect, GL_SHADER_STATE_RECORD, shader) {
                 shader.enable_clipping = true;