From: Thomas De Schampheleire Date: Tue, 1 Jun 2021 14:34:17 +0000 (+0200) Subject: package/sofia-sip: don't set 'NDEBUG' explicitly X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=0993954814e8f54c7fea5dcb6dff1cc2c3d3e780;p=buildroot.git package/sofia-sip: don't set 'NDEBUG' explicitly BR2_ENABLE_DEBUG should just steer the availability of debug symbols and should have no negative effect on performance. Introduction of 'assert' statements, 'debug'-type builds with additional logging, etc. should be steered by BR2_ENABLE_RUNTIME_DEBUG instead. The sofia-sip package was setting '--enable-ndebug' conditionally based on BR2_ENABLE_DEBUG, and this would have to be updated to be based on BR2_ENABLE_RUNTIME_DEBUG. However, the sofia-sip option '--enable-ndebug' only sets the 'NDEBUG' preprocessor macro, and the core package infrastructure already sets this macro correctly based on BR2_ENABLE_RUNTIME_DEBUG. This means that the explicit '--enable-ndebug' flag can be removed. Suggested-by: Arnout Vandecappelle (Essensium/Mind) Signed-off-by: Thomas De Schampheleire Signed-off-by: Yann E. MORIN --- diff --git a/package/sofia-sip/sofia-sip.mk b/package/sofia-sip/sofia-sip.mk index 274c72fce8..fb565637eb 100644 --- a/package/sofia-sip/sofia-sip.mk +++ b/package/sofia-sip/sofia-sip.mk @@ -30,8 +30,4 @@ SOFIA_SIP_CONF_OPTS += \ --without-openssl endif -ifeq ($(BR2_ENABLE_DEBUG),) -SOFIA_SIP_CONF_OPTS += --enable-ndebug -endif - $(eval $(autotools-package))