From: Jason Ekstrand Date: Tue, 25 Jun 2019 19:26:56 +0000 (-0500) Subject: anv/descriptor_set: Only write texture swizzles if we have an image view X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=0a364a4a74e774030cde542ba8be90008b3f1211;p=mesa.git anv/descriptor_set: Only write texture swizzles if we have an image view When immutable samplers are set we call write_image_view with a NULL image view. This causes issues on IVB where we have to fake texture swizzling. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110999 Fixes: d2aa65eb18 "anv: Emulate texture swizzle in the shader when..." --- diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c index a6b49468f73..f4e00667334 100644 --- a/src/intel/vulkan/anv_descriptor_set.c +++ b/src/intel/vulkan/anv_descriptor_set.c @@ -1198,7 +1198,7 @@ anv_descriptor_set_write_image_view(struct anv_device *device, anv_descriptor_set_write_image_param(desc_map, image_param); } - if (bind_layout->data & ANV_DESCRIPTOR_TEXTURE_SWIZZLE) { + if (image_view && (bind_layout->data & ANV_DESCRIPTOR_TEXTURE_SWIZZLE)) { assert(!(bind_layout->data & ANV_DESCRIPTOR_SAMPLED_IMAGE)); assert(image_view); struct anv_texture_swizzle_descriptor desc_data[3];