From: Tomasz Figa Date: Tue, 2 Aug 2016 10:46:25 +0000 (+0900) Subject: gallium/winsys/kms: Fix double refcount when importing from prime FD (v2) X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=0aa6a818ef60e01f304987fe07ac1370d68d38b1;p=mesa.git gallium/winsys/kms: Fix double refcount when importing from prime FD (v2) Currently the code creates a display target struct with refcount field initialized to 1 and then the caller again increments it, leading to a leaked reference. Let's remove the unnecessary increment. v2: Split from one big patch into four fixing one thing at a time. Signed-off-by: Tomasz Figa CC: Reviewed-by: Hans de Goede Reviewed-by: Emil Velikov --- diff --git a/src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c b/src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c index 21ac0d7dae8..0585fcce207 100644 --- a/src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c +++ b/src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c @@ -276,7 +276,6 @@ kms_sw_displaytarget_from_handle(struct sw_winsys *ws, case DRM_API_HANDLE_TYPE_FD: kms_sw_dt = kms_sw_displaytarget_add_from_prime(kms_sw, whandle->handle); if (kms_sw_dt) { - kms_sw_dt->ref_count++; kms_sw_dt->width = templ->width0; kms_sw_dt->height = templ->height0; kms_sw_dt->stride = whandle->stride;