From: whitequark <whitequark@whitequark.org>
Date: Thu, 8 Aug 2019 05:28:01 +0000 (+0000)
Subject: proc_prune: fix handling of exactly identical assigns.
X-Git-Tag: working-ls180~1158^2
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=0b09a347dc0163ee19fd4aaa4d306bc82ce7d6d8;p=yosys.git

proc_prune: fix handling of exactly identical assigns.

Before this commit, in a process like:
   process $proc$bug.v:8$3
     assign $foo \bar
     switch \sel
       case 1'1
         assign $foo 1'1
         assign $foo 1'1
       case
         assign $foo 1'0
     end
   end
both of the "assign $foo 1'1" would incorrectly be removed.

Fixes #1243.
---

diff --git a/passes/proc/proc_prune.cc b/passes/proc/proc_prune.cc
index b47ee79c2..d4aee9df0 100644
--- a/passes/proc/proc_prune.cc
+++ b/passes/proc/proc_prune.cc
@@ -65,8 +65,7 @@ struct PruneWorker
 			pool<RTLIL::SigBit> sw_assigned = do_switch((*it), assigned, affected);
 			assigned.insert(sw_assigned.begin(), sw_assigned.end());
 		}
-		pool<RTLIL::SigSig> remove;
-		for (auto it = cs->actions.rbegin(); it != cs->actions.rend(); ++it) {
+		for (auto it = cs->actions.rbegin(); it != cs->actions.rend(); ) {
 			RTLIL::SigSpec lhs = sigmap(it->first);
 			bool redundant = true;
 			for (auto &bit : lhs) {
@@ -75,9 +74,10 @@ struct PruneWorker
 					break;
 				}
 			}
+			bool remove = false;
 			if (redundant) {
 				removed_count++;
-				remove.insert(*it);
+				remove = true;
 			} else {
 				if (root) {
 					bool promotable = true;
@@ -99,7 +99,7 @@ struct PruneWorker
 						}
 						promoted_count++;
 						module->connect(conn);
-						remove.insert(*it);
+						remove = true;
 					}
 				}
 				for (auto &bit : lhs)
@@ -109,11 +109,9 @@ struct PruneWorker
 					if (bit.wire)
 						affected.insert(bit);
 			}
-		}
-		for (auto it = cs->actions.begin(); it != cs->actions.end(); ) {
-			if (remove[*it]) {
-				it = cs->actions.erase(it);
-			} else it++;
+			if (remove)
+				cs->actions.erase((it++).base() - 1);
+			else it++;
 		}
 		return assigned;
 	}