From: Mike Stump <mrs@apple.com>
Date: Sat, 24 Jul 2004 07:32:15 +0000 (+0000)
Subject: c-typeck.c (convert_for_assignment): Tightened up pointer converstions that differ... 
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=0c6d842886b9dce2a675dd484526522ddfe7dd12;p=gcc.git

c-typeck.c (convert_for_assignment): Tightened up pointer converstions that differ in signedness.

        * c-typeck.c (convert_for_assignment): Tightened up pointer converstions
        that differ in signedness.
Apple Radar 2535328.

From-SVN: r85114
---

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index be41b26cf01..0c8219d00d0 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@
+2004-07-23  Mike Stump  <mrs@apple.com>
+
+	* c-typeck.c (convert_for_assignment): Tightened up pointer converstions
+	that differ in signedness.
+
 2004-07-23  Zack Weinberg  <zack@codesourcery.com>
 
 	* genmodes.c (make_vector_modes): Mark with ATTRIBUTE_UNUSED.
diff --git a/gcc/c-typeck.c b/gcc/c-typeck.c
index 8d201cdbda5..ba92b2e9fff 100644
--- a/gcc/c-typeck.c
+++ b/gcc/c-typeck.c
@@ -3472,7 +3472,7 @@ convert_for_assignment (tree type, tree rhs, const char *errtype,
 		       || target_cmp)
 		;
 	      /* If there is a mismatch, do warn.  */
-	      else if (pedantic)
+	      else
 		warn_for_assignment ("pointer targets in %s differ in signedness",
 				     errtype, funname, parmnum);
 	    }
diff --git a/gcc/testsuite/gcc.dg/conv-2.c b/gcc/testsuite/gcc.dg/conv-2.c
new file mode 100644
index 00000000000..349c8acceed
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/conv-2.c
@@ -0,0 +1,26 @@
+/* { dg-do compile } */
+/* { dg-options "" } */
+
+void f1(long *);
+void f2(unsigned long *);
+
+int main()
+{
+  long *lp;
+  unsigned long *ulp;
+  char *cp;
+  unsigned char *ucp;
+  signed char *scp;
+
+  ulp = lp;	/* { dg-warning " pointer targets in assignment differ in signedness" } */
+  lp = ulp;	/* { dg-warning " pointer targets in assignment differ in signedness" } */
+  f1(ulp);	/* { dg-warning " differ in signedness" } */
+  f2(lp);	/* { dg-warning " differ in signedness" } */
+
+  cp = ucp;	/* { dg-warning " pointer targets in assignment differ in signedness" } */
+  cp = scp;	/* { dg-warning " pointer targets in assignment differ in signedness" } */
+  ucp = scp;	/* { dg-warning " pointer targets in assignment differ in signedness" } */
+  ucp = cp;	/* { dg-warning " pointer targets in assignment differ in signedness" } */
+  scp = ucp;	/* { dg-warning " pointer targets in assignment differ in signedness" } */
+  scp = cp;	/* { dg-warning " pointer targets in assignment differ in signedness" } */
+}