From: Jason Ekstrand <jason.ekstrand@intel.com>
Date: Wed, 23 Sep 2015 00:16:59 +0000 (-0700)
Subject: nir/lower_alu_to_scalar: Return after lower_reduction
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=0f9bf647705db48a88c700bfa7ca3d4a9f6b4f56;p=mesa.git

nir/lower_alu_to_scalar: Return after lower_reduction

We don't use any of the code after the switch anyway.  Since we check for
num_components == 1 and early-return, it doesn't get executed so
everything's ok.  However, it makes it much clearer what's going on if we
simply do an early return.

Reviewed-by: Matt Turner <mattst88@gmail.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
---

diff --git a/src/glsl/nir/nir_lower_alu_to_scalar.c b/src/glsl/nir/nir_lower_alu_to_scalar.c
index 5ef5ec2b316..84d4943befc 100644
--- a/src/glsl/nir/nir_lower_alu_to_scalar.c
+++ b/src/glsl/nir/nir_lower_alu_to_scalar.c
@@ -86,7 +86,7 @@ lower_alu_instr_scalar(nir_alu_instr *instr, nir_builder *b)
    case name##3: \
    case name##4: \
       lower_reduction(instr, chan, merge, b); \
-      break;
+      return;
 
    switch (instr->op) {
    case nir_op_vec4: