From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Date: Mon, 16 Sep 2019 14:47:12 +0000 (+0300)
Subject: util/xmlconfig: fix regexp compile failure check
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=10206ba17b3f685035418b2ab99b10ea261600e1;p=mesa.git

util/xmlconfig: fix regexp compile failure check

This is embarrasing...

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 04dc6074cf ("driconfig: add a new engine name/version parameter")
Reviewed-by: Eric Engestrom <eric.engestrom@intel.com>
---

diff --git a/src/util/xmlconfig.c b/src/util/xmlconfig.c
index 4b77ea7624f..64363522d2f 100644
--- a/src/util/xmlconfig.c
+++ b/src/util/xmlconfig.c
@@ -794,7 +794,7 @@ parseEngineAttr(struct OptConfData *data, const XML_Char **attr)
     if (engine_name_match) {
        regex_t re;
 
-       if (regcomp (&re, engine_name_match, REG_EXTENDED|REG_NOSUB) != 0) {
+       if (regcomp (&re, engine_name_match, REG_EXTENDED|REG_NOSUB) == 0) {
           if (regexec (&re, data->engineName, 0, NULL, 0) == REG_NOMATCH)
              data->ignoringApp = data->inApp;
           regfree (&re);