From: Gabe Black <gabeblack@google.com>
Date: Sat, 24 Mar 2018 01:03:24 +0000 (-0700)
Subject: scons: Re-enable override based warnings on gcc.
X-Git-Tag: v19.0.0.0~2202
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=1148c9f2f3f75d04982a7a0b6ce037608affb058;p=gem5.git

scons: Re-enable override based warnings on gcc.

These warnings have been fixed.

Change-Id: I28ee5f4ae21412121849fcb9d273939d8e462842
Reviewed-on: https://gem5-review.googlesource.com/9344
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com>
Maintainer: Gabe Black <gabeblack@google.com>
---

diff --git a/SConstruct b/SConstruct
index 0bb0f69a2..8fde13338 100755
--- a/SConstruct
+++ b/SConstruct
@@ -478,10 +478,6 @@ if main['GCC']:
     main.Append(TCMALLOC_CCFLAGS=['-fno-builtin-malloc', '-fno-builtin-calloc',
                                   '-fno-builtin-realloc', '-fno-builtin-free'])
 
-    # add option to check for undeclared overrides
-    if compareVersions(gcc_version, "5.0") > 0:
-        main.Append(CCFLAGS=['-Wno-error=suggest-override'])
-
     # The address sanitizer is available for gcc >= 4.8
     if GetOption('with_asan'):
         if GetOption('with_ubsan') and \