From: Ken Raeburn <raeburn@cygnus>
Date: Thu, 19 Jan 1995 21:04:08 +0000 (+0000)
Subject: gcc lint
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=11618ce8f284e45b1eea6a60e4f1a662d971c5f6;p=binutils-gdb.git

gcc lint
---

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 66327c6663a..d1e0ac51de7 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,5 +1,25 @@
 Thu Jan 19 14:49:47 1995  Ken Raeburn  <raeburn@cujo.cygnus.com>
 
+	* config/tc-alpha.c (alpha_ip): Initialize local variables to keep
+	gcc quiet.
+	(gpdisp_hi16_howto): Don't use "const" with reloc_howto_type.
+	(in_range_signed): Add parens around subtraction inside shift.
+	* gasp.c (do_data): Initialize local variable "opname".
+	(istrue): Provide a default case to set "res" and keep "gcc -Wall"
+	quiet.
+	* write.c (write_contents): Deleted unused variable.
+	(print_symbol_value_1): Declare.
+	* hash.c (hash_ask): Delete disabled non-strcmp version of the
+	code, and automatic variables used only in those sections.
+	* write.c (chain_frchains_together_1): Only define local variable
+	"prev_fix" if BFD_ASSEMBLER.
+	* flonum-konst.c (dummy1): Return void.
+	* config/tc-vax.c (md_assemble): Remove two comparisons of
+	unsigned numbers versus zero.
+
+	* config/tc-alpha.c, config/alpha-opcode.h: Revert 2 June changes.
+	Turns out we never got the assignment done after all.
+
 	Cleanup of VAX and VMS code, from Pat Rankin:
 	* config/obj-vms.c: Changed exported function names to lower case.
 	(Changed call sites in write.c.)  Declare VMS system function
diff --git a/gas/gasp.c b/gas/gasp.c
index be7260cbc18..3d120a4087a 100644
--- a/gas/gasp.c
+++ b/gas/gasp.c
@@ -1494,7 +1494,7 @@ do_data (idx, in, size)
      int size;
 {
   int opsize = 4;
-  char *opname;
+  char *opname = ".yikes!";
   sb acc;
   sb_new (&acc);
 
@@ -2351,6 +2351,9 @@ istrue (idx, in)
 	  idx = exp_get_abs ("Conditional operator must have absolute operands.\n", idx, in, &valb);
 	  switch (cond)
 	    {
+	    default:
+	      res = 42;
+	      break;
 	    case EQ:
 	      res = vala == valb;
 	      break;
diff --git a/gas/hash.c b/gas/hash.c
index 2d2190c2d89..e8894f8ce5e 100644
--- a/gas/hash.c
+++ b/gas/hash.c
@@ -678,9 +678,7 @@ hash_ask (handle, string, access)
      const char *string;
      int access;		/* access type */
 {
-  const char *string1;	/* JF avoid strcmp calls */
   const char *s;
-  int c;
   struct hash_entry *slot;
   int collision;	/* count collisions */
 
@@ -692,22 +690,8 @@ hash_ask (handle, string, access)
   hash_found = FALSE;
   while (((s = slot->hash_string) != NULL) && s != DELETED)
     {
-#if 1
       if (string == s || !strcmp (string, s))
 	hash_found = TRUE;
-#else
-      for (string1 = string;;)
-	{
-	  if ((c = *s++) == 0)
-	    {
-	      if (!*string1)
-		hash_found = TRUE;
-	      break;
-	    }
-	  if (*string1++ != c)
-	    break;
-	}
-#endif
       if (hash_found)
 	break;
       collision++;
@@ -726,21 +710,8 @@ hash_ask (handle, string, access)
       slot = handle->hash_where;/* now look again */
       while (((s = slot->hash_string) != NULL) && s != DELETED)
 	{
-#if 0
-	  for (string1 = string; *s; string1++, s++)
-	    {
-	      if (*string1 != *s)
-		break;
-	    }
-	  if (*s == *string1)
-	    {
-	      hash_found = TRUE;
-	      break;
-	    }
-#else
 	  if (string == s || !strcmp (string, s))
 	    hash_found = TRUE;
-#endif
 	  collision++;
 	  slot++;
 	}