From: Enze Li <lienze2010@hotmail.com>
Date: Fri, 28 Jan 2022 13:26:40 +0000 (+0800)
Subject: gdb/build: Fix Wpessimizing-move in clang build
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=12735d34728d540ca39b8158da0ed1e257fa8f50;p=binutils-gdb.git

gdb/build: Fix Wpessimizing-move in clang build

When building with clang, I run into an error:

...
tui/tui-disasm.c:138:25: error: moving a temporary object prevents copy
elision [-Werror,-Wpessimizing-move]
      tal.addr_string = std::move (gdb_dis_out.release ());
                        ^
tui/tui-disasm.c:138:25: note: remove std::move call here
      tal.addr_string = std::move (gdb_dis_out.release ());
                        ^~~~~~~~~~~                      ~
...

The error above is caused by the recent commit 5d10a2041eb8 ("gdb: add
string_file::release method").

Fix this by removing std::move.

Build on x86_64-linux with clang 13.0.0.
---

diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c
index 445503a5af9..70f7429d32b 100644
--- a/gdb/tui/tui-disasm.c
+++ b/gdb/tui/tui-disasm.c
@@ -135,7 +135,7 @@ tui_disassemble (struct gdbarch *gdbarch,
       /* And capture the address the instruction is at.  */
       tal.addr = orig_pc;
       print_address (gdbarch, orig_pc, &gdb_dis_out);
-      tal.addr_string = std::move (gdb_dis_out.release ());
+      tal.addr_string = gdb_dis_out.release ();
 
       if (addr_size != nullptr)
 	{