From: Eric Anholt <eric@anholt.net>
Date: Wed, 21 Nov 2012 22:33:52 +0000 (-0800)
Subject: i965: Stop making a copy of non-builtin uniforms in ParameterValues[].
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=12751ef2a70f2e8ce06b116d69e475dfa5dc6f38;p=mesa.git

i965: Stop making a copy of non-builtin uniforms in ParameterValues[].

We don't need them now that our set of parameter pointers points at the
GL core storage for them.  This should save memory/bandwidth/overhead in
uniform updates.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
---

diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp
index 951b5f4fedb..1e8d57485ad 100644
--- a/src/mesa/drivers/dri/i965/brw_shader.cpp
+++ b/src/mesa/drivers/dri/i965/brw_shader.cpp
@@ -100,9 +100,6 @@ brw_link_shader(struct gl_context *ctx, struct gl_shader_program *shProg)
 	return false;
       prog->Parameters = _mesa_new_parameter_list();
 
-      _mesa_generate_parameters_list_for_uniforms(shProg, &shader->base,
-						  prog->Parameters);
-
       if (stage == 0) {
 	 struct gl_vertex_program *vp = (struct gl_vertex_program *) prog;
 	 vp->UsesClipDistance = shProg->Vert.UsesClipDistance;