From: Romain Naour <romain.naour@smile.fr>
Date: Fri, 19 Jan 2018 10:15:03 +0000 (+0100)
Subject: package/dash: add /etc/dash to /etc/shells
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=129f3276989de6f07ba02eb3fe175f731f2ae9a8;p=buildroot.git

package/dash: add /etc/dash to /etc/shells

When dash is selected, /bin/dash is not added to /etc/shells
(see man shells). So, login tools like dropbear reject the ssh
connections for users using dash as shell in /etc/passwd.

buildroot authpriv.warn dropbear[853]: User 'kubu' has invalid shell, rejected

Signed-off-by: Romain Naour <romain.naour@smile.fr>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---

diff --git a/package/dash/dash.mk b/package/dash/dash.mk
index 2ee292b8d3..9a26ebb642 100644
--- a/package/dash/dash.mk
+++ b/package/dash/dash.mk
@@ -28,4 +28,12 @@ define DASH_INSTALL_TARGET_CMDS
 	$(INSTALL) -m 0755 $(@D)/src/dash $(TARGET_DIR)/bin/dash
 endef
 
+# Add /bin/dash to /etc/shells otherwise some login tools like dropbear
+# can reject the user connection. See man shells.
+define DASH_ADD_DASH_TO_SHELLS
+	grep -qsE '^/bin/dash$$' $(TARGET_DIR)/etc/shells \
+		|| echo "/bin/dash" >> $(TARGET_DIR)/etc/shells
+endef
+DASH_TARGET_FINALIZE_HOOKS += DASH_ADD_DASH_TO_SHELLS
+
 $(eval $(autotools-package))