From: John Baldwin <jhb@FreeBSD.org>
Date: Tue, 2 Aug 2022 21:54:28 +0000 (-0700)
Subject: fbsd-nat: Correct the return type of the have_regset method.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=13db4a0c4d307541926e503ed066b3bc17277678;p=binutils-gdb.git

fbsd-nat: Correct the return type of the have_regset method.

During the development of 40c23d880386d6e8202567eaa2a6b041feb1a652,
the return value of fbsd_nat_target::have_regset was changed from a
simple boolean to returning the size of the register set.  The
comments and callers were all updated for this change, but the actual
return type was accidentally left as a bool.  This change fixes the
return type to be a size_t.

Current callers of this only checked the value against 0 and thus
still worked correctly.
---

diff --git a/gdb/fbsd-nat.c b/gdb/fbsd-nat.c
index a4ca4a53415..f38d5d8745b 100644
--- a/gdb/fbsd-nat.c
+++ b/gdb/fbsd-nat.c
@@ -1779,7 +1779,7 @@ fbsd_nat_target::store_register_set (struct regcache *regcache, int regnum,
 
 /* See fbsd-nat.h.  */
 
-bool
+size_t
 fbsd_nat_target::have_regset (ptid_t ptid, int note)
 {
   pid_t pid = get_ptrace_pid (ptid);
diff --git a/gdb/fbsd-nat.h b/gdb/fbsd-nat.h
index eb7d29dd2a3..7a0510c32bd 100644
--- a/gdb/fbsd-nat.h
+++ b/gdb/fbsd-nat.h
@@ -190,7 +190,7 @@ protected:
      the size of the register set is returned.  If the register set is
      not present, zero is returned.  */
 
-  bool have_regset (ptid_t ptid, int note);
+  size_t have_regset (ptid_t ptid, int note);
 
   /* Wrapper versions of the PT_GETREGSET and PT_REGSET helpers which
      accept a register set type.  */